[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [konsole] src/tests: simplify the color testing
From:       Kurt Hindenburg <kurt.hindenburg () gmail ! com>
Date:       2013-09-01 0:41:09
Message-ID: E1VFvj3-0003nW-22 () scm ! kde ! org
[Download RAW message or body]

Git commit 79cb3598d4f77c408dd515fa8be2e70bd37463d2 by Kurt Hindenburg.
Committed on 01/09/2013 at 00:40.
Pushed by hindenburg into branch 'master'.

simplify the color testing

M  +1    -4    src/tests/TerminalTest.cpp

http://commits.kde.org/konsole/79cb3598d4f77c408dd515fa8be2e70bd37463d2

diff --git a/src/tests/TerminalTest.cpp b/src/tests/TerminalTest.cpp
index f1203ba..db65d7b 100644
--- a/src/tests/TerminalTest.cpp
+++ b/src/tests/TerminalTest.cpp
@@ -48,7 +48,7 @@ void TerminalTest::testScrollBarPositions()
 void TerminalTest::testColorTable()
 {
     // These are from ColorScheme.cpp but they can be anything to test
-    ColorEntry defaultTable[TABLE_COLORS] = {
+    const ColorEntry defaultTable[TABLE_COLORS] = {
         ColorEntry(QColor(0x00, 0x00, 0x00)), ColorEntry(QColor(0xFF, 0xFF, 0xFF)),
         ColorEntry(QColor(0x00, 0x00, 0x00)), ColorEntry(QColor(0xB2, 0x18, 0x18)),
         ColorEntry(QColor(0x18, 0xB2, 0x18)), ColorEntry(QColor(0xB2, 0x68, 0x18)),
@@ -75,15 +75,12 @@ void TerminalTest::testColorTable()
 
     // UseCurrentFormat is the default FontWeight
     colorEntry =  ColorEntry(QColor(0x00, 0x00, 0x00), ColorEntry::Bold);
-    defaultTable[0] = colorEntry;
     QVERIFY(colorTable[0] != colorEntry);
 
     colorEntry =  ColorEntry(QColor(0x00, 0x00, 0x00), ColorEntry::Normal);
-    defaultTable[0] = colorEntry;
     QVERIFY(colorTable[0] != colorEntry);
 
     colorEntry =  ColorEntry(QColor(0x00, 0x00, 0x00), ColorEntry::UseCurrentFormat);
-    defaultTable[0] = colorEntry;
     QVERIFY(colorTable[0] == colorEntry);
 
     delete display;
[prev in list] [next in list] [prev in thread] [next in thread]