[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [ktp-common-internals] KTp/Declarative: Revert "windows build fix"
From:       Aleix Pol <aleixpol () kde ! org>
Date:       2013-08-01 1:06:00
Message-ID: E1V4hL6-0001uA-Qg () scm ! kde ! org
[Download RAW message or body]

Git commit 463050f11228f92f255f61cf6530e7f366e9223b by Aleix Pol.
Committed on 01/08/2013 at 01:04.
Pushed by apol into branch 'master'.

Revert "windows build fix"

This reverts commit 201de3a1c8a593b62a165a2644db388bbec13182.
The commit is not correct because even though it compiles it stops
working.
Why is this change needed? There's no qulonglong on windows? I've
just seen that in my system WId is ulong, maybe we could use that...

CCMAIL: vonreth@kde.org

M  +1    -1    KTp/Declarative/hide-window-component.cpp
M  +1    -2    KTp/Declarative/hide-window-component.h

http://commits.kde.org/telepathy-common-internals/463050f11228f92f255f61cf6530e7f366e9223b

diff --git a/KTp/Declarative/hide-window-component.cpp b/KTp/Declarative/hide-window-component.cpp
index d462ae8..bf8f24b 100644
--- a/KTp/Declarative/hide-window-component.cpp
+++ b/KTp/Declarative/hide-window-component.cpp
@@ -25,7 +25,7 @@ HideWindowComponent::HideWindowComponent(QObject *parent)
 {
 }
 
-void HideWindowComponent::hideWindowFromTaskbar(WId winId)
+void HideWindowComponent::hideWindowFromTaskbar(qulonglong winId)
 {
     KWindowSystem::setState(winId, NET::SkipTaskbar | NET::SkipPager);
 }
diff --git a/KTp/Declarative/hide-window-component.h b/KTp/Declarative/hide-window-component.h
index 115c436..78d0bff 100644
--- a/KTp/Declarative/hide-window-component.h
+++ b/KTp/Declarative/hide-window-component.h
@@ -20,7 +20,6 @@
 #define HIDEWINDOWCOMPONENT_H
 
 #include <QObject>
-#include <QWidget>
 
 /**
  * Plasma is not exposing such a feature to make its dialogs hidden from the taskbar,
@@ -33,7 +32,7 @@ class HideWindowComponent : public QObject
   public:
     explicit HideWindowComponent(QObject *parent = 0);
 
-    Q_SCRIPTABLE void hideWindowFromTaskbar(WId winId);
+    Q_SCRIPTABLE void hideWindowFromTaskbar(qulonglong winId);
 };
 
 #endif // HIDEWINDOWCOMPONENT_H
[prev in list] [next in list] [prev in thread] [next in thread]