[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [ark] kerfuffle: Emit finished() when runProcess does not find any program.
From:       Raphael Kubo da Costa <rakuco () FreeBSD ! org>
Date:       2013-06-30 17:06:09
Message-ID: E1UtL4j-00029H-64 () scm ! kde ! org
[Download RAW message or body]

Git commit a3736e60172d604144b5eee7c62600066f6e2d6c by Raphael Kubo da Costa.
Committed on 30/06/2013 at 16:59.
Pushed by rkcosta into branch 'master'.

Emit finished() when runProcess does not find any program.

This fixes a regression introduced in c7af2d6: while the `finished' signal
will be emitted correctly in most cases, if none of the executables passed
to CliInterface::runProcess() are found only the `error' signal would be
sent, and the program would wait for a `finished' signal forever and never
notify the user that the required programs were not found.

Submitted by:	Ádám István Mózes <sajtos@sch.bme.hu>
BUG:		319663
REVIEW:		111318
FIXED-IN:	4.11.0

M  +1    -0    kerfuffle/cliinterface.cpp

http://commits.kde.org/ark/a3736e60172d604144b5eee7c62600066f6e2d6c

diff --git a/kerfuffle/cliinterface.cpp b/kerfuffle/cliinterface.cpp
index 3cbe31b..79ae085 100644
--- a/kerfuffle/cliinterface.cpp
+++ b/kerfuffle/cliinterface.cpp
@@ -330,6 +330,7 @@ bool CliInterface::runProcess(const QStringList& programNames, \
const QStringList  const QString names = programNames.join(QLatin1String(", "));
         emit error(i18ncp("@info", "Failed to locate program <filename>%2</filename> \
                on disk.",
                                    "Failed to locate programs \
<filename>%2</filename> on disk.", programNames.count(), names)); +        emit \
finished(false);  return false;
     }
 


[prev in list] [next in list] [prev in thread] [next in thread]