[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: [amarok] src: more unused private members removed
From: Edward Toroshchin <edward.hades () gmail ! com>
Date: 2013-06-22 19:22:07
Message-ID: E1UqTNv-0007bR-Gi () scm ! kde ! org
[Download RAW message or body]
Git commit 57d2c7f129bd2b9e83f40006a45d40532fc02fa9 by Edward Toroshchin.
Committed on 22/06/2013 at 19:16.
Pushed by hades into branch 'master'.
more unused private members removed
Please double check the "never been used" items, especially if the
authors are still available.
ServiceBrowser::m_usingContextView has been left over since
dd303617dd2cf0c0113f710660df78fba38421d6
SqlPodcastEpisode::m_batchUpdate has never been used since its
introduction in 680b5102d0f9f011ec993d5277b3a9b417848443
Transcoding::AssistantDialog::m_defaultEncoder has never been used
(introduced in 1a0287f7925d92a05a530ab83fffbc9afae67e86)
AppletToolbarAppletItem::m_labelPadding left over after
568bfcb808ad43bfad39b20441a291a6392f4092
LikeBackDialog::m_requestNumber_ unused in the library imported in
f4683691c5ddc692de2f3ccf54f4d8316c807c4c
DynamicView::m_expandToggledWhenPressed _was_ used, but the code has
always been commented out since 40b768ec4a08d23dceea8f72df1c601574614081
and removed completely in 2fe7dd743c66b2fb9f9a6bbb7b2d50730a843056
Daap::Reader::m_loadedTracks has never been used since patch of
382d427f87f6702a5431b325c56be3b79de45b6c
OpmlDirectoryMetaFactory::m_service never used (introduced in
19eb9efe689628de819842487fde489bddaca13b)
M +0 -1 src/browsers/playlistbrowser/DynamicView.cpp
M +0 -3 src/browsers/playlistbrowser/DynamicView.h
M +0 -1 src/browsers/servicebrowser/ServiceBrowser.cpp
M +0 -1 src/browsers/servicebrowser/ServiceBrowser.h
M +0 -3 src/context/toolbar/AppletToolbarAppletItem.cpp
M +0 -1 src/context/toolbar/AppletToolbarAppletItem.h
M +1 -0 src/core-impl/collections/aggregate/AggregateMeta.cpp
M +0 -1 src/core-impl/podcasts/sql/SqlPodcastMeta.cpp
M +0 -2 src/core-impl/podcasts/sql/SqlPodcastMeta.h
M +3 -1 src/services/ampache/AmpacheMeta.h
M +1 -2 src/services/opmldirectory/OpmlDirectoryMeta.cpp
M +0 -3 src/services/opmldirectory/OpmlDirectoryMeta.h
M +1 -0 src/statusbar/PopupWidget.cpp
M +0 -1 src/transcoding/TranscodingAssistantDialog.cpp
M +0 -1 src/transcoding/TranscodingAssistantDialog.h
http://commits.kde.org/amarok/57d2c7f129bd2b9e83f40006a45d40532fc02fa9
diff --git a/src/browsers/playlistbrowser/DynamicView.cpp \
b/src/browsers/playlistbrowser/DynamicView.cpp index 99bb4be..5d7b54a 100644
--- a/src/browsers/playlistbrowser/DynamicView.cpp
+++ b/src/browsers/playlistbrowser/DynamicView.cpp
@@ -49,7 +49,6 @@
PlaylistBrowserNS::DynamicView::DynamicView( QWidget *parent )
: Amarok::PrettyTreeView( parent )
- , m_expandToggledWhenPressed( false )
{
DEBUG_BLOCK
setHeaderHidden( true );
diff --git a/src/browsers/playlistbrowser/DynamicView.h \
b/src/browsers/playlistbrowser/DynamicView.h index b1f64bd..649c695 100644
--- a/src/browsers/playlistbrowser/DynamicView.h
+++ b/src/browsers/playlistbrowser/DynamicView.h
@@ -57,9 +57,6 @@ protected:
virtual void mouseDoubleClickEvent( QMouseEvent *event );
virtual void contextMenuEvent( QContextMenuEvent* event );
-
-private:
- bool m_expandToggledWhenPressed;
};
} // namespace PlaylistBrowserNS
diff --git a/src/browsers/servicebrowser/ServiceBrowser.cpp \
b/src/browsers/servicebrowser/ServiceBrowser.cpp index 751d6a3..9e2335e 100644
--- a/src/browsers/servicebrowser/ServiceBrowser.cpp
+++ b/src/browsers/servicebrowser/ServiceBrowser.cpp
@@ -33,7 +33,6 @@ ServiceBrowser * ServiceBrowser::instance()
ServiceBrowser::ServiceBrowser( const QString& name, QWidget* parent )
: BrowserCategoryList( name, parent, true )
- , m_usingContextView( false )
{
debug() << "ServiceBrowser starting...";
diff --git a/src/browsers/servicebrowser/ServiceBrowser.h \
b/src/browsers/servicebrowser/ServiceBrowser.h index 05b68df..0249efc 100644
--- a/src/browsers/servicebrowser/ServiceBrowser.h
+++ b/src/browsers/servicebrowser/ServiceBrowser.h
@@ -81,7 +81,6 @@ class ServiceBrowser : public BrowserCategoryList
static ServiceBrowser *s_instance;
ScriptableServiceManager *m_scriptableServiceManager;
- bool m_usingContextView;
QTimer m_filterTimer;
diff --git a/src/context/toolbar/AppletToolbarAppletItem.cpp \
b/src/context/toolbar/AppletToolbarAppletItem.cpp index b5f0e2b..53db14e 100644
--- a/src/context/toolbar/AppletToolbarAppletItem.cpp
+++ b/src/context/toolbar/AppletToolbarAppletItem.cpp
@@ -39,7 +39,6 @@ Context::AppletToolbarAppletItem::AppletToolbarAppletItem( \
QGraphicsItem* parent , m_applet( applet )
, m_label( 0 )
, m_deleteIcon( 0 )
- , m_labelPadding( 5 )
, m_configEnabled( false )
{
m_label = new QGraphicsTextItem( this );
@@ -153,10 +152,8 @@ Context::AppletToolbarAppletItem::sizeHint( Qt::SizeHint which, \
const QSizeF & c {
Q_UNUSED( constraint )
if( which == Qt::MinimumSize )
- // return QSizeF( m_label->boundingRect().width() + 2 * m_labelPadding, \
QGraphicsWidget::sizeHint( which, constraint ).height() ); return QSizeF();
else
- // return QGraphicsWidget::sizeHint( which, constraint );
return QSizeF( 10000, 10000 );
}
diff --git a/src/context/toolbar/AppletToolbarAppletItem.h \
b/src/context/toolbar/AppletToolbarAppletItem.h index 8a4bb32..1339fcf 100644
--- a/src/context/toolbar/AppletToolbarAppletItem.h
+++ b/src/context/toolbar/AppletToolbarAppletItem.h
@@ -83,7 +83,6 @@ class AppletToolbarAppletItem : public AppletToolbarBase
Plasma::IconWidget* m_deleteIcon;
- int m_labelPadding;
bool m_configEnabled;
};
diff --git a/src/core-impl/collections/aggregate/AggregateMeta.cpp \
b/src/core-impl/collections/aggregate/AggregateMeta.cpp index 83c5c04..1e63d99 100644
--- a/src/core-impl/collections/aggregate/AggregateMeta.cpp
+++ b/src/core-impl/collections/aggregate/AggregateMeta.cpp
@@ -1464,6 +1464,7 @@ AggregateLabel::AggregateLabel( \
Collections::AggregateCollection *coll, const Me , m_name( label->name() )
{
m_labels.append( label );
+ Q_UNUSED(m_collection); // might be needed later
}
AggregateLabel::~AggregateLabel()
diff --git a/src/core-impl/podcasts/sql/SqlPodcastMeta.cpp \
b/src/core-impl/podcasts/sql/SqlPodcastMeta.cpp index fda8008..73192a8 100644
--- a/src/core-impl/podcasts/sql/SqlPodcastMeta.cpp
+++ b/src/core-impl/podcasts/sql/SqlPodcastMeta.cpp
@@ -115,7 +115,6 @@ SqlPodcastEpisode::toPodcastEpisodeList( SqlPodcastEpisodeList \
episodes )
SqlPodcastEpisode::SqlPodcastEpisode( const QStringList &result, \
SqlPodcastChannelPtr sqlChannel )
: Podcasts::PodcastEpisode( Podcasts::PodcastChannelPtr::staticCast( sqlChannel \
) )
- , m_batchUpdate( false )
, m_channel( sqlChannel )
{
SqlStorage *sqlStorage = CollectionManager::instance()->sqlStorage();
diff --git a/src/core-impl/podcasts/sql/SqlPodcastMeta.h \
b/src/core-impl/podcasts/sql/SqlPodcastMeta.h index cbf06ae..02a18d3 100644
--- a/src/core-impl/podcasts/sql/SqlPodcastMeta.h
+++ b/src/core-impl/podcasts/sql/SqlPodcastMeta.h
@@ -86,8 +86,6 @@ class SqlPodcastEpisode : public Podcasts::PodcastEpisode
*/
void setupLocalFile();
- bool m_batchUpdate;
-
int m_dbId; //database ID
bool m_isKeep; //Keep the download after purge or not?
SqlPodcastChannelPtr m_channel; //the parent of this episode
diff --git a/src/services/ampache/AmpacheMeta.h b/src/services/ampache/AmpacheMeta.h
index 303c43a..5f98078 100644
--- a/src/services/ampache/AmpacheMeta.h
+++ b/src/services/ampache/AmpacheMeta.h
@@ -43,7 +43,9 @@ public:
: ServiceTrack( title )
, m_service( service )
, m_discNumber( 0 )
- {}
+ {
+ Q_UNUSED(m_service); // might be used again later
+ }
virtual QString sourceName() { return "Ampache"; }
virtual QString sourceDescription() { return "The Ampache music server project: \
http://Ampache.org"; }
diff --git a/src/services/opmldirectory/OpmlDirectoryMeta.cpp \
b/src/services/opmldirectory/OpmlDirectoryMeta.cpp index 5a6ccea..1a6d8e8 100644
--- a/src/services/opmldirectory/OpmlDirectoryMeta.cpp
+++ b/src/services/opmldirectory/OpmlDirectoryMeta.cpp
@@ -22,9 +22,8 @@
using namespace Meta;
-OpmlDirectoryMetaFactory::OpmlDirectoryMetaFactory( const QString & dbPrefix, \
OpmlDirectoryService * service ) +OpmlDirectoryMetaFactory::OpmlDirectoryMetaFactory( \
const QString & dbPrefix, OpmlDirectoryService * ) : ServiceMetaFactory( dbPrefix )
- , m_service( service )
{
}
diff --git a/src/services/opmldirectory/OpmlDirectoryMeta.h \
b/src/services/opmldirectory/OpmlDirectoryMeta.h index cfc1ad3..0b262ff 100644
--- a/src/services/opmldirectory/OpmlDirectoryMeta.h
+++ b/src/services/opmldirectory/OpmlDirectoryMeta.h
@@ -35,9 +35,6 @@ class OpmlDirectoryMetaFactory : public ServiceMetaFactory
virtual Meta::TrackPtr createTrack( const QStringList &rows );
virtual Meta::AlbumPtr createAlbum( const QStringList &rows );
-
- private:
- OpmlDirectoryService * m_service;
};
diff --git a/src/statusbar/PopupWidget.cpp b/src/statusbar/PopupWidget.cpp
index f59cdce..a56d552 100644
--- a/src/statusbar/PopupWidget.cpp
+++ b/src/statusbar/PopupWidget.cpp
@@ -25,6 +25,7 @@ PopupWidget::PopupWidget( QWidget *anchor, const QString &name )
: KVBox( The::mainWindow() )
{
Q_UNUSED( name );
+ Q_UNUSED( anchor );
setBackgroundRole( QPalette::Window );
setAutoFillBackground( true );
diff --git a/src/transcoding/TranscodingAssistantDialog.cpp \
b/src/transcoding/TranscodingAssistantDialog.cpp index b1c76d8..17fc250 100644
--- a/src/transcoding/TranscodingAssistantDialog.cpp
+++ b/src/transcoding/TranscodingAssistantDialog.cpp
@@ -30,7 +30,6 @@ AssistantDialog::AssistantDialog( const QStringList \
&playableFileTypes, bool sav const Configuration &prevConfiguration,
QWidget *parent )
: KDialog( parent, Qt::Dialog )
- , m_defaultEncoder( VORBIS )
, m_configuration( JUST_COPY )
, m_save( false )
, m_playableFileTypes( playableFileTypes )
diff --git a/src/transcoding/TranscodingAssistantDialog.h \
b/src/transcoding/TranscodingAssistantDialog.h index a8eb6aa..0acb701 100644
--- a/src/transcoding/TranscodingAssistantDialog.h
+++ b/src/transcoding/TranscodingAssistantDialog.h
@@ -63,7 +63,6 @@ private:
inline void populateFormatList();
Configuration::TrackSelection trackSelection() const;
- Encoder m_defaultEncoder;
Configuration m_configuration;
bool m_save;
QStringList m_playableFileTypes;
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic