[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [amarok] src: remove some unused private class members
From:       Edward Toroshchin <edward.hades () gmail ! com>
Date:       2013-06-18 16:15:31
Message-ID: 20130618161531.D1F6FA605A () git ! kde ! org
[Download RAW message or body]

Git commit 48e2393482827bea0e68f71e1b398d4e6c79db84 by Edward Toroshchin.
Committed on 18/06/2013 at 18:08.
Pushed by hades into branch 'master'.

remove some unused private class members

BrowserCategory::m_breadcrumb became unused in commit
f32932a9422177a17facd46c5e5f8c7384ed598c

SingleCollectionTreeItemModel::m_queryMaker has been unused ever since
its introduction in 82e26c6077afae56fd080df6ea418d4a7e1269de

Applet::m_isMessageShown has been obsolete since the commit
8e4dd4f6242d368b36b53e155b892d837bbc0120

CoverManager::m_parent is unused since the code cleanup of
21e87710ea91faa2f919c1e2d302934045f93dcc

And ServiceCollection::m_metaFactory again appears to never have been
used since its first appearance before live audience in the fine day of
f489e4d71ebe844703b392e69a09068b4b68509f

M  +0    -1    src/browsers/BrowserCategory.cpp
M  +0    -2    src/browsers/BrowserCategory.h
M  +0    -1    src/browsers/SingleCollectionTreeItemModel.h
M  +0    -1    src/context/Applet.h
M  +0    -1    src/covermanager/CoverManager.cpp
M  +0    -1    src/covermanager/CoverManager.h
M  +0    -2    src/services/ServiceCollection.h

http://commits.kde.org/amarok/48e2393482827bea0e68f71e1b398d4e6c79db84

diff --git a/src/browsers/BrowserCategory.cpp b/src/browsers/BrowserCategory.cpp
index d648ce3..c6f848b 100644
--- a/src/browsers/BrowserCategory.cpp
+++ b/src/browsers/BrowserCategory.cpp
@@ -29,7 +29,6 @@ BrowserCategory::BrowserCategory( const QString &name, QWidget *parent )
     : KVBox( parent )
     , m_name( name )
     , m_parentList( 0 )
-    , m_breadcrumb( 0 )
 {
     setObjectName( name );
     setSizePolicy( QSizePolicy::Expanding, QSizePolicy::Expanding );
diff --git a/src/browsers/BrowserCategory.h b/src/browsers/BrowserCategory.h
index 80c91c6..5b8fa6b 100644
--- a/src/browsers/BrowserCategory.h
+++ b/src/browsers/BrowserCategory.h
@@ -174,8 +174,6 @@ private:
     QString m_imagePath;
     BrowserCategoryList * m_parentList;
 
-    BrowserBreadcrumbItem * m_breadcrumb;
-
     QList<BrowserBreadcrumbItem *> m_additionalItems;
 
 };
diff --git a/src/browsers/SingleCollectionTreeItemModel.h b/src/browsers/SingleCollectionTreeItemModel.h
index 8afd050..cf3a358 100644
--- a/src/browsers/SingleCollectionTreeItemModel.h
+++ b/src/browsers/SingleCollectionTreeItemModel.h
@@ -53,7 +53,6 @@ class AMAROK_EXPORT SingleCollectionTreeItemModel: public CollectionTreeItemMode
     private:
 
         Collections::Collection* m_collection;
-        Collections::QueryMaker* m_queryMaker;
 };
 
 #endif
diff --git a/src/context/Applet.h b/src/context/Applet.h
index cfca86e..28e8cd5 100644
--- a/src/context/Applet.h
+++ b/src/context/Applet.h
@@ -194,7 +194,6 @@ class AMAROK_EXPORT Applet : public Plasma::Applet
         void cleanUpAndDelete();
 
         bool m_transient;
-        bool m_isMessageShown;
         qreal m_standardPadding;
         QWeakPointer<QPropertyAnimation> m_animation;
 };
diff --git a/src/covermanager/CoverManager.cpp b/src/covermanager/CoverManager.cpp
index 328a12e..8530a5b 100644
--- a/src/covermanager/CoverManager.cpp
+++ b/src/covermanager/CoverManager.cpp
@@ -831,7 +831,6 @@ CoverView::setStatusText( QListWidgetItem *item )
 CoverViewItem::CoverViewItem( QListWidget *parent, Meta::AlbumPtr album )
     : QListWidgetItem( parent )
     , m_albumPtr( album)
-    , m_parent( parent )
 {
     m_album = album->prettyName();
     if( album->hasAlbumArtist() )
diff --git a/src/covermanager/CoverManager.h b/src/covermanager/CoverManager.h
index ca1d1dc..2e43dd4 100644
--- a/src/covermanager/CoverManager.h
+++ b/src/covermanager/CoverManager.h
@@ -183,7 +183,6 @@ class CoverViewItem : public QListWidgetItem
         QString m_album;
         QString m_coverImagePath;
         bool    m_embedded;
-        QListWidget *m_parent;
 };
 
 #endif
diff --git a/src/services/ServiceCollection.h b/src/services/ServiceCollection.h
index 7b47011..3628707 100644
--- a/src/services/ServiceCollection.h
+++ b/src/services/ServiceCollection.h
@@ -102,8 +102,6 @@ class AMAROK_EXPORT ServiceCollection : public Collections::Collection
         ServiceBase * m_service;
         QSharedPointer<MemoryCollection> m_mc;
 
-        ServiceMetaFactory * m_metaFactory;
-
         QString m_collectionId;
         QString m_prettyName;
 
[prev in list] [next in list] [prev in thread] [next in thread]