[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [libqapt/2.0] src: Don't leak the file descriptor.
From:       Jonathan Thomas <echidnaman () kubuntu ! org>
Date:       2013-06-18 14:18:02
Message-ID: 20130618141802.AE72EA605A () git ! kde ! org
[Download RAW message or body]

Git commit afaddf2cdebcb370b2ce7678aa2c90ddb1665f43 by Jonathan Thomas.
Committed on 18/06/2013 at 16:17.
Pushed by jmthomas into branch '2.0'.

Don't leak the file descriptor.

M  +2    -0    src/backend.cpp

http://commits.kde.org/libqapt/afaddf2cdebcb370b2ce7678aa2c90ddb1665f43

diff --git a/src/backend.cpp b/src/backend.cpp
index 008f268..16d80a7 100644
--- a/src/backend.cpp
+++ b/src/backend.cpp
@@ -1354,6 +1354,7 @@ bool Backend::setPackagePinned(Package *package, bool=
 pin)
 =

             pkgTagFile tagFile(&Fd);
             if (_error->PendingError()) {
+                fclose(out);
                 return false;
             }
 =

@@ -1375,6 +1376,7 @@ bool Backend::setPackagePinned(Package *package, bool=
 pin)
                     fprintf(out, "\n");
                 }
             }
+            fclose(out);
 =

             if (!tempFile.open()) {
                 return false;
[prev in list] [next in list] [prev in thread] [next in thread]