[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kdelibs/frameworks] tier1/solid/src/solid/backends/udisks2: Fix build when udisks2 is enabled
From:       David Faure <faure () kde ! org>
Date:       2013-06-05 21:24:18
Message-ID: 3928845.uOUpX1cek4 () asterix
[Download RAW message or body]

On Wednesday 05 June 2013 21:00:51 Andrea Scarpino wrote:
> Git commit 71ef88c8c327dbffd3c1eeae3b6de7dfba9efbc5 by Andrea Scarpino.
> Committed on 05/06/2013 at 20:59.
> Pushed by scarpino into branch 'frameworks'.
> 
> Fix build when udisks2 is enabled
> 
> REVIEW: 110841
> 
> M  +6    -6    tier1/solid/src/solid/backends/udisks2/udisksdevice.cpp
> M  +7    -2   
> tier1/solid/src/solid/backends/udisks2/udisksdevicebackend.cpp M  +2    -1 
>   tier1/solid/src/solid/backends/udisks2/udisksdevicebackend.h
> 
> http://commits.kde.org/kdelibs/71ef88c8c327dbffd3c1eeae3b6de7dfba9efbc5
> 
> diff --git a/tier1/solid/src/solid/backends/udisks2/udisksdevice.cpp
> b/tier1/solid/src/solid/backends/udisks2/udisksdevice.cpp index
> 5bbf2ac..b30a37e 100644
> --- a/tier1/solid/src/solid/backends/udisks2/udisksdevice.cpp
> +++ b/tier1/solid/src/solid/backends/udisks2/udisksdevice.cpp
> @@ -61,31 +61,31 @@ static QString formatByteSize(double size)
>      {
>          size /= 1073741824.0;
>          if ( size > 1024 ) // Tebi-byte
> -            s = tr("%1 TiB").arg(QLocale().toString(size / 1024.0, 'f',
>+            s = QObject::tr("%1 TiB").arg(QLocale().toString(size /

The tr() documentation really needs to say more explicitely:
DO NOT WRITE QObject::tr(). This code isn't in the QObject class, so the 
context shouldn't be QObject. For code outside of a QObject subclass, use 
QCoreApplication::translate() to provide an actual context string.

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

[prev in list] [next in list] [prev in thread] [next in thread]