[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kde-workspace/KDE/4.10] plasma/generic/wallpapers/image: Plasma Wallpaper Image Plugin: Avoid unnec
From:       Vishesh Handa <me () vhanda ! in>
Date:       2013-05-17 18:02:56
Message-ID: 20130517180256.1C246A6071 () git ! kde ! org
[Download RAW message or body]

Git commit 3ae865333c40b9fb4de09d2c0a6cf00ec50a0382 by Vishesh Handa.
Committed on 10/05/2013 at 19:27.
Pushed by vhanda into branch 'KDE/4.10'.

Plasma Wallpaper Image Plugin: Avoid unnecessary renders of the wallpaper

When the selection in changed in the view, that calls Image::pictureChanged
which then calls setSingleImage which sends the image for rendering.
Once the image has been rendered, updateBackground is called which
starts the fading animation. This is completely unnessary.

M  +0    -2    plasma/generic/wallpapers/image/image.cpp

http://commits.kde.org/kde-workspace/3ae865333c40b9fb4de09d2c0a6cf00ec50a0382

diff --git a/plasma/generic/wallpapers/image/image.cpp b/plasma/generic/wallpapers/image/image.cpp
index 006a748..a44cc4f 100644
--- a/plasma/generic/wallpapers/image/image.cpp
+++ b/plasma/generic/wallpapers/image/image.cpp
@@ -612,8 +612,6 @@ void Image::pictureChanged(const QModelIndex &index)
     } else {
         m_wallpaper = b->path();
     }
-
-    setSingleImage();
 }
 
 void Image::positioningChanged(int index)
[prev in list] [next in list] [prev in thread] [next in thread]