From kde-commits  Wed May 08 10:42:49 2013
From: Mark Kretschmann <kretschmann () kde ! org>
Date: Wed, 08 May 2013 10:42:49 +0000
To: kde-commits
Subject: [amarok] src/context/engines/wikipedia: Fix crashes on track change (both with Phonon-GStreamer and
Message-Id: <20130508104249.7D575A605B () git ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-commits&m=136800978907117

Git commit d13bd61842627ffb2382b5d59a020ea7a5124ca5 by Mark Kretschmann.
Committed on 08/05/2013 at 12:29.
Pushed by markey into branch 'master'.

Fix crashes on track change (both with Phonon-GStreamer and Phonon-VLC).

What happened:

The Wikipedia applet uses QtWebKit for HTML rendering. On
Linux, QtWebKit uses GStreamer for media playback. Turns out that this cras=
hes
with a high probability whenever an <audio> tag is present on a web page. As
music artists' pages often contain audio snippets in Vorbis format, it cras=
hed
a lot when Amarok's applet rendered a page.

The fix:

Removing all audio tags from Wikipedia pages before rendering them in our a=
pplet.
Of course, the real fix would have to be done upstream. But until that happ=
ens, our
workaround here fixes a shitload of crashes.

We might want to do a 2.7.1 release for Linux, with this patch.

CCMAIL: amarok-devel@kde.org

M  +14   -0    src/context/engines/wikipedia/WikipediaEngine.cpp

http://commits.kde.org/amarok/d13bd61842627ffb2382b5d59a020ea7a5124ca5

diff --git a/src/context/engines/wikipedia/WikipediaEngine.cpp b/src/contex=
t/engines/wikipedia/WikipediaEngine.cpp
index 94910e7..0692b8d 100644
--- a/src/context/engines/wikipedia/WikipediaEngine.cpp
+++ b/src/context/engines/wikipedia/WikipediaEngine.cpp
@@ -818,6 +818,20 @@ WikipediaEnginePrivate::wikiParse( QString &wiki )
         }
     }
 =

+    { // remove <audio> tags (can lead to crashes in QtWebKit)
+        const QString tag    =3D QLatin1String("<audio");
+        const QString tagEnd =3D QLatin1String("</audio>");
+        const int tagEndSize =3D tagEnd.size();
+        int matchIndex =3D 0;
+        QStringMatcher tagMatcher( tag );
+        while( (matchIndex =3D tagMatcher.indexIn(wiki, matchIndex)) !=3D =
-1 )
+        {
+            const int nToTagEnd =3D wiki.indexOf( tagEnd, matchIndex ) - m=
atchIndex;
+            QStringRef tagRef =3D wiki.midRef( matchIndex, nToTagEnd + tag=
EndSize );
+            wiki.remove( tagRef.toString() );
+        }
+    }
+
     // Adding back style and license information
     wiki =3D QLatin1String("<div id=3D\"bodyContent\"") + wiki;
     wiki +=3D copyright;