[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kapptemplate] templates/QML/qml-plasmoid/package: Polishing the new QML Plasmoid template
From:       Aleix Pol <aleixpol () kde ! org>
Date:       2013-04-16 23:51:29
Message-ID: 20130416235129.BBDB4A605E () git ! kde ! org
[Download RAW message or body]

Git commit 6536a7af059ec8b25ffdfbc78f14fb5e240f653e by Aleix Pol.
Committed on 17/04/2013 at 01:51.
Pushed by apol into branch 'master'.

Polishing the new QML Plasmoid template

In QML:
- Fix indentation (there were mixed spaces and tabs)
- Remove unneeded import (org.kde.locale, it's not needed for i18n to work)

In the desktop file:
- Don't put the Name as if it was in different languages, just put the
original. If translators need to have it in different languages, they'll
change it (or actually scripty). Same with the comment.
- Don't announce as PopupApplet

CCMAIL: annma@kde.org

M  +24   -27   templates/QML/qml-plasmoid/package/contents/ui/plasmoid.qml
M  +1    -61   templates/QML/qml-plasmoid/package/metadata.desktop

http://commits.kde.org/kapptemplate/6536a7af059ec8b25ffdfbc78f14fb5e240f653e

diff --git a/templates/QML/qml-plasmoid/package/contents/ui/plasmoid.qml \
b/templates/QML/qml-plasmoid/package/contents/ui/plasmoid.qml index b8cfc58..752b5c7 \
                100644
--- a/templates/QML/qml-plasmoid/package/contents/ui/plasmoid.qml
+++ b/templates/QML/qml-plasmoid/package/contents/ui/plasmoid.qml
@@ -17,39 +17,36 @@
  *   51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA .        *
  ***************************************************************************/
 
-import QtQuick 1.0;
+import QtQuick 1.1
 import org.kde.plasma.core 0.1 as PlasmaCore
 import org.kde.plasma.components 0.1 as PlasmaComponents
-import org.kde.locale 0.1 as Locale
 
 Item {
-    id: main;
-
-    property int minimumWidth: 210;
-    property int minimumHeight: 210;
+    property int minimumWidth: 210
+    property int minimumHeight: 210
 
     PlasmaCore.Svg {
-      //Instantiate a svg instance, set the svg image path
-      id: mySvg
-      imagePath: plasmoid.file("images", "pairs.svgz")
-      
+        //Instantiate a svg, set the svg image path
+        id: mySvg
+        imagePath: plasmoid.file("images", "pairs.svgz")
     }
-    
+
     Column {
-      spacing: 10;
-      id:column
-      
-      PlasmaCore.SvgItem {
-	id: mySvgItem
-	width: 180; height: 180
-	anchors { horizontalCenter: column.horizontalCenter }
-	svg: mySvg //use the svg instanciated above
-      }
-      
-      PlasmaComponents.Label {
-	  text: i18n("A column with a SVG and a label")
-	  anchors { horizontalCenter: column.horizontalCenter }
-	  //the text color is set by the plasma theme
-      }
+        spacing: 10
+
+        PlasmaCore.SvgItem {
+            id: mySvgItem
+            width: 180
+            height: 180
+            anchors.horizontalCenter: parent.horizontalCenter
+            svg: mySvg //use the svg instanciated above
+        }
+
+        PlasmaComponents.Label {
+            text: i18n("A column with a SVG and a label")
+            anchors {
+                horizontalCenter: parent.horizontalCenter
+            }
+        }
     }
-}
\ No newline at end of file
+}
diff --git a/templates/QML/qml-plasmoid/package/metadata.desktop \
b/templates/QML/qml-plasmoid/package/metadata.desktop index aa73f38..9be4b14 100644
--- a/templates/QML/qml-plasmoid/package/metadata.desktop
+++ b/templates/QML/qml-plasmoid/package/metadata.desktop
@@ -1,70 +1,10 @@
 [Desktop Entry]
 Name=%{APPNAME}
-Name[ast]=%{APPNAME}
-Name[bg]=%{APPNAME}
-Name[bs]=%{APPNAME}
-Name[ca]=%{APPNAME}
-Name[ca@valencia]=%{APPNAME}
-Name[cs]=%{APPNAME}
-Name[da]=%{APPNAME}
-Name[de]=%{APPNAME}
-Name[el]=%{APPNAME}
-Name[en_GB]=%{APPNAME}
-Name[eo]=%{APPNAME}
-Name[es]=%{APPNAME}
-Name[et]=%{APPNAME}
-Name[fi]=%{APPNAME}
-Name[fr]=%{APPNAME}
-Name[ga]=%{APPNAME}
-Name[gl]=%{APPNAME}
-Name[hu]=%{APPNAME}
-Name[it]=%{APPNAME}
-Name[ja]=%{APPNAME}
-Name[kk]=%{APPNAME}
-Name[km]=%{APPNAME}
-Name[ko]=%{APPNAME}
-Name[lt]=%{APPNAME}
-Name[lv]=%{APPNAME}
-Name[nb]=%{APPNAME}
-Name[nds]=%{APPNAME}
-Name[nl]=%{APPNAME}
-Name[nn]=%{APPNAME}
-Name[pa]=%{APPNAME}
-Name[pl]=%{APPNAME}
-Name[pt]=%{APPNAME}
-Name[pt_BR]=%{APPNAME}
-Name[ro]=%{APPNAME}
-Name[ru]=%{APPNAME}
-Name[sk]=%{APPNAME}
-Name[sq]=%{APPNAME}
-Name[sr]=%{APPNAME}
-Name[sr@ijekavian]=%{APPNAME}
-Name[sr@ijekavianlatin]=%{APPNAME}
-Name[sr@latin]=%{APPNAME}
-Name[sv]=%{APPNAME}
-Name[tr]=%{APPNAME}
-Name[ug]=%{APPNAME}
-Name[uk]=%{APPNAME}
-Name[x-test]=xx%{APPNAME}xx
-Name[zh_CN]=%{APPNAME}
-Name[zh_TW]=%{APPNAME}
 Comment=what your app does in a few words
-Comment[de]=Kurze Bescheibung, was Ihre Anwendung tut
-Comment[nb]=hva programmet gjør, med noen få ord
-Comment[nl]=wat uw app in een paar woorden doet
-Comment[pt]=o que a sua aplicação faz, em poucas palavras
-Comment[pt_BR]=breve descrição do que o seu aplicativo faz
-Comment[sr]=Неколико речи о намени програма
-Comment[sr@ijekavian]=Неколико речи о намени програма
-Comment[sr@ijekavianlatin]=Nekoliko reči o nameni programa
-Comment[sr@latin]=Nekoliko reči o nameni programa
-Comment[sv]=vad programmet gör med några få ord
-Comment[uk]=призначення вашої програми у декількох \
                словах
-Comment[x-test]=xxwhat your app does in a few wordsxx
 
 Icon=applications-system
 Type=Service
-ServiceTypes=Plasma/Applet,Plasma/PopupApplet
+ServiceTypes=Plasma/Applet
 
 
 X-KDE-Library=plasma_applet_%{APPNAMELC}


[prev in list] [next in list] [prev in thread] [next in thread]