[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [rekonq] src/webwindow: pass menutitle through i18n() to get it localized -.-
From:       Lukáš Tinkl <ltinkl () redhat ! com>
Date:       2013-04-16 10:22:47
Message-ID: 516D2677.6040501 () redhat ! com
[Download RAW message or body]

Dne 16.4.2013 12:03, Harald Sitter napsal(a):
> On Tue, Apr 16, 2013 at 11:45 AM, Lukáš Tinkl <ltinkl@redhat.com
> <mailto:ltinkl@redhat.com>> wrote:
>
>     Dne 16.4.2013 11:14, Harald Sitter napsal(a):
>
>         Git commit 824427e2fe2a840c53ec97d98c63ab__8c1a988393 by Harald
>         Sitter.
>         Committed on 16/04/2013 at 11:14.
>         Pushed by sitter into branch 'master'.
>
>         pass menutitle through i18n() to get it localized -.-
>
>         M  +1    -1    src/webwindow/rekonqfactory.__cpp
>
>         http://commits.kde.org/rekonq/__824427e2fe2a840c53ec97d98c63ab__8c1a988393
>         <http://commits.kde.org/rekonq/824427e2fe2a840c53ec97d98c63ab8c1a988393>
>
>         diff --git a/src/webwindow/rekonqfactory.__cpp
>         b/src/webwindow/rekonqfactory.__cpp
>         index af15bf4..86c60b5 100644
>         --- a/src/webwindow/rekonqfactory.__cpp
>         +++ b/src/webwindow/rekonqfactory.__cpp
>         @@ -322,7 +322,7 @@ void RekonqFactory::fillMenu(KMenu *m,
>         QDomNode node)
>
>                    if (el.tagName() == QL1S("text"))
>                    {
>         -            const QString menuTitle = el.text();
>         +            const QString menuTitle = i18n(qPrintable(el.text()));
>                        m->setTitle(menuTitle);
>                    }
>
>
>
>     The qPrintable() kinda scares me there... why is it there?
>
>
> Because .text() is a QString; i18n works on char * though; qPrintable
> makes the QString a char * for i18n.

Ah, ok but it's still wrong, it will break the string anyway; Pino fixed 
it meanwhile

-- 
Lukáš Tinkl <ltinkl@redhat.com>
Software Engineer - KDE desktop team, Brno
KDE developer <lukas@kde.org>
Red Hat Inc.                               http://cz.redhat.com
[prev in list] [next in list] [prev in thread] [next in thread]