[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [phonon-gstreamer/1.0-porting-for-merge] gstreamer: remove crappy old deprecated unused code to fix
From:       Harald Sitter <sitter () kde ! org>
Date:       2013-04-11 19:07:28
Message-ID: 20130411190728.6BAC3A605E () git ! kde ! org
[Download RAW message or body]

Git commit 7be665d20e40294acaa839b48e95df59bfddeb7a by Harald Sitter.
Committed on 11/04/2013 at 21:06.
Pushed by sitter into branch '1.0-porting-for-merge'.

remove crappy old deprecated unused code to fix a crash

apparently the property got here either is NULL or not a guint anymore,
therefore screwing up the stack and leading to insanely silly crashes

M  +2    -12   gstreamer/pipeline.cpp

http://commits.kde.org/phonon-gstreamer/7be665d20e40294acaa839b48e95df59bfddeb7a

diff --git a/gstreamer/pipeline.cpp b/gstreamer/pipeline.cpp
index b06fedc..4efcbbc 100644
--- a/gstreamer/pipeline.cpp
+++ b/gstreamer/pipeline.cpp
@@ -725,18 +725,8 @@ gboolean Pipeline::cb_tag(GstBus *bus, GstMessage *msg, gpointer data)
                 else
                     that->m_metaData.insert("ALBUM", "Streaming Data");
             }
-            // As we manipulate the title, we need to recompare
-            // oldMap and m_metaData here...
-            //if (oldMap != m_metaData && !m_loading)
-
-            // Only emit signal if we're on a live stream.
-            // Its a kludgy hack that for 99% of cases of streaming should work.
-            // If not, this needs fixed in mediaobject.cpp.
-            guint kbps;
-            g_object_get(that->m_pipeline, "connection-speed", &kbps, NULL);
-	    // This hack does not work now.
-            // if (that->m_currentSource.discType() == Phonon::Cd || kbps != 0)
-                emit that->metaDataChanged(that->m_metaData);
+
+            emit that->metaDataChanged(that->m_metaData);
         }
     }
     return true;

[prev in list] [next in list] [prev in thread] [next in thread]