[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kwordquiz] src: Krazy fixes: Dialog crash guards.
From:       Peter Hedlund <peter () peterandlinda ! com>
Date:       2013-03-10 22:55:12
Message-ID: 20130310225512.1E891A604F () git ! kde ! org
[Download RAW message or body]

Git commit 9c7e459db539ddf33f3c85ca3c480fba428647e9 by Peter Hedlund.
Committed on 10/03/2013 at 23:55.
Pushed by hedlund into branch 'master'.

Krazy fixes: Dialog crash guards.

M  +6    -4    src/kwordquiz.cpp
M  +3    -2    src/kwqtableview.cpp

http://commits.kde.org/kwordquiz/9c7e459db539ddf33f3c85ca3c480fba428647e9

diff --git a/src/kwordquiz.cpp b/src/kwordquiz.cpp
index 2c263a0..5b2e7a0 100644
--- a/src/kwordquiz.cpp
+++ b/src/kwordquiz.cpp
@@ -829,19 +829,21 @@ void KWordQuizApp::slotFileOpenRecent(const KUrl& url)
 
 void KWordQuizApp::slotFileGHNS()
 {
-  KNS3::DownloadDialog getHotNewStuffDialog("kwordquiz.knsrc", this);
-  getHotNewStuffDialog.exec();  
+  QPointer<KNS3::DownloadDialog> getHotNewStuffDialog = new \
KNS3::DownloadDialog("kwordquiz.knsrc", this); +  getHotNewStuffDialog->exec();
+  KNS3::Entry::List entries = getHotNewStuffDialog->changedEntries();
   
   // list of changed entries
-  foreach(const KNS3::Entry& entry, getHotNewStuffDialog.changedEntries()) {
+  foreach(const KNS3::Entry& entry, entries) {
     // check mime type and if kvtml, open it	
     foreach(const QString &file, entry.installedFiles()) { 
       KMimeType::Ptr mimeType = KMimeType::findByPath(file);
       if (mimeType->name() == "application/x-kvtml") {
-	KProcess::startDetached("kwordquiz", QStringList() << file);
+	    KProcess::startDetached("kwordquiz", QStringList() << file);
       }
     }
   }
+  delete getHotNewStuffDialog;
 }
 
 
diff --git a/src/kwqtableview.cpp b/src/kwqtableview.cpp
index 9d9f067..3669ed6 100644
--- a/src/kwqtableview.cpp
+++ b/src/kwqtableview.cpp
@@ -88,10 +88,11 @@ void KWQTableView::doPrint()
 void KWQTableView::doPrintPreview()
 {
   QPrinter printer;
-  KPrintPreview preview(&printer, this);
+  QPointer<KPrintPreview> preview = new KPrintPreview(&printer, this);
   QTextDocument td;
   createPages(&printer, &td, true);
-  preview.exec();
+  preview->exec();
+  delete preview;
 }
 
 bool KWQTableView::doHtmlExport(const KUrl &url)


[prev in list] [next in list] [prev in thread] [next in thread]