[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [digikam] libs/models: Coverity: possible endless loop, or loop which never ran
From:       Marcel Wiesweg <marcel.wiesweg () gmx ! de>
Date:       2013-01-31 21:39:20
Message-ID: 20130131213920.2D517A60D4 () git ! kde ! org
[Download RAW message or body]

Git commit b38be47af8c5612e2ae5f68aa593220518c54bc5 by Marcel Wiesweg.
Committed on 31/01/2013 at 22:32.
Pushed by mwiesweg into branch 'master'.

Coverity: possible endless loop, or loop which never ran

M  +2    -2    libs/models/imagefiltermodel.cpp

http://commits.kde.org/digikam/b38be47af8c5612e2ae5f68aa593220518c54bc5

diff --git a/libs/models/imagefiltermodel.cpp b/libs/models/imagefiltermodel.cpp
index 383f209..a96c0db 100644
--- a/libs/models/imagefiltermodel.cpp
+++ b/libs/models/imagefiltermodel.cpp
@@ -819,7 +819,7 @@ void ImageFilterModel::slotRowsInserted(const QModelIndex& /*parent*/, int start
 {
     QList<ImageInfo> infos;
 
-    for (int i=start; i>end; ++i)
+    for (int i=start; i<=end; ++i)
     {
         infos << imageInfo(index(i, 0));
     }
@@ -831,7 +831,7 @@ void ImageFilterModel::slotRowsAboutToBeRemoved(const QModelIndex& /*parent*/, i
 {
     QList<ImageInfo> infos;
 
-    for (int i=start; i>end; ++i)
+    for (int i=start; i<=end; ++i)
     {
         infos << imageInfo(index(i, 0));
     }

[prev in list] [next in list] [prev in thread] [next in thread]