[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kde-workspace/aseigo/krunner-qml] ksmserver/screenlocker: the notifications are not only pointl
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2013-01-22 19:15:20
Message-ID: 1985201.U2Qh7EcIfD () freedom
[Download RAW message or body]


On Tuesday, January 22, 2013 19:33:19 Oswald Buddenhagen wrote:
> On Tue, Jan 22, 2013 at 07:23:32PM +0100, Aaron J. Seigo wrote:
> > the notifications are not only pointless, they are annoying
> 
> lubos added them for a reason, though: as a hook for running scripts.

knotify is completely the wrong method to accomplish that.

besides incurring multiple round trips through the dbus server and all too 
easily gets turned on. i've seen these notifications on numerous computers that 
are not mine.

if one wants to run scripts on lock/unlock, this needs to be done elsewhere. 
we have powerdevil that handles some of these things now, but it would be 
rather more sensible to put that feature right into the lock process.

> after much complaining from me he disabled them by default. if they are
> back, you broke it.

and now they are gone for good .. well, at least in this branch. which is why 
we do feature branch based devel, of course: so we can break things without 
actually breaking things :)

that said, to bring back this feature, i'll want some damn good use cases. the 
amount of cruft we've removed in kde-workspace that once made sense is pretty 
amazing. keeping every feature just because it was added at some point in time 
in the past is not a pathway to good software. it just results in a massive 
katamari ball of cruft in which somewhere are the actual code paths and 
features that need attention paid to them. (kwin's dbus call to cycle through 
different desktop windows comes to mind here)

-- 
Aaron J. Seigo
["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]