[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdelibs] kioslave/http/kcookiejar: Initialise the mCrossDomain member variable in the cookies
From:       Thiago Macieira <thiago.macieira () intel ! com>
Date:       2013-01-18 11:22:31
Message-ID: 20130118112231.D74CAA6091 () git ! kde ! org
[Download RAW message or body]

Git commit 794b14b8af5b610fc3eed6945f93f0c69dd49a9a by Thiago Macieira.
Committed on 18/01/2013 at 12:12.
Pushed by thiago into branch 'master'.

Initialise the mCrossDomain member variable in the cookies

For several months now, all my cookies would be forgotten after a kded
restart. After debugging the problem, turns out that mCrossDomain was
of value 127, which makes no sense for a boolean.

This variable has been present since 2002, which means that the
"reject cross domain cookies" feature has been broken for 10 years and
8 months.

M  +1    -0    kioslave/http/kcookiejar/kcookiejar.cpp

http://commits.kde.org/kdelibs/794b14b8af5b610fc3eed6945f93f0c69dd49a9a

diff --git a/kioslave/http/kcookiejar/kcookiejar.cpp b/kioslave/http/kcooki=
ejar/kcookiejar.cpp
index 8d94dcf..4f3ac4d 100644
--- a/kioslave/http/kcookiejar/kcookiejar.cpp
+++ b/kioslave/http/kcookiejar/kcookiejar.cpp
@@ -183,6 +183,7 @@ KHttpCookie::KHttpCookie(const QString &_host,
        mExpireDate(_expireDate),
        mProtocolVersion(_protocolVersion),
        mSecure(_secure),
+       mCrossDomain(false),
        mHttpOnly(_httpOnly),
        mExplicitPath(_explicitPath),
        mUserSelectedAdvice(KCookieDunno)
[prev in list] [next in list] [prev in thread] [next in thread]