[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kdelibs/frameworks] /: kstandarddirs.h does not need to depend on kglobal.h
From:       David Faure <faure () kde ! org>
Date:       2012-12-29 0:30:26
Message-ID: 43796565.dOOKQTtVRU () asterix ! site
[Download RAW message or body]

On Friday 28 December 2012 15:44:52 Albert Astals Cid wrote:
> Git commit 42f3688d4eaf1027067fc4b0aca285c4f8d2b88e by Albert Astals Cid.
> Committed on 28/12/2012 at 15:43.
> Pushed by aacid into branch 'frameworks'.
> 
> kstandarddirs.h does not need to depend on kglobal.h

The goal for kstandarddirs is to end up in kde4support (since QStandardPaths 
replaces its heart) -- well kstandarddirs provides extra convenience, but I'm 
not sure if it's worth keeping (and ensuring it's fully correct), compared to 
porting the code to direct QStandardPaths usage (as already documented in 
KDE5PORTING.html).

So if it goes into kde4support, there isn't much point in making its header 
cleaner.... OK except that untangling deps helps us with moving stuff, shorter 
term, of course.

I'm not objecting, just raising the obvious point that cleaning up headers 
leads to more porting work in all apps.

> David, this probably breaks the qt5 build since plasma is not build in the
> qt4 part, can you have a look? CCMAIL: dfaure@kde.org

Yep, I'm checking compilation, no problem.

However we were discussing requiring Qt5 soon; would that be a problem for 
you? I certainly don't want to discourage you from contributing, these 
cleanups are very good overall :-)

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

[prev in list] [next in list] [prev in thread] [next in thread]