From kde-commits Tue Dec 25 20:40:35 2012 From: Kevin Krammer Date: Tue, 25 Dec 2012 20:40:35 +0000 To: kde-commits Subject: [kdepim] /: Several EBN Krazy fixes Message-Id: <20121225204035.B2E83A6091 () git ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-commits&m=135646804617283 Git commit 5b1a43ffab4bd5ef491a5bb3492e3a5c086aa552 by Kevin Krammer. Committed on 25/12/2012 at 21:39. Pushed by krake into branch 'master'. Several EBN Krazy fixes Fixing various issues found by the EnglishBreakfastNetwork's code checker Krazy. Submitted by Kyle Morris , completing a Google Code-in task. CCMAIL: codeinkyle@gmail.com REVIEW: 107912 DIGEST: Google Code-in contribution M +1 -1 blogilo/src/bilbopost.h M +1 -1 calendarsupport/incidenceattachmentmodel.h M +1 -1 calendarsupport/next/incidenceviewer.h M +1 -1 knode/kscoring.h M +1 -1 korganizer/kocheckableproxymodel.h M +1 -1 messagecore/attachmentfromfolderjob.h M +1 -1 messagecore/attachmentfromurlbasejob.h M +1 -1 messagelist/core/item_p.h M +1 -1 messagelist/core/messageitem_p.h M +1 -1 messagelist/core/model.h M +1 -1 messagelist/core/modelinvariantrowmapper_p.h M +1 -1 messagelist/utils/aggregationcombobox_p.h M +1 -1 messagelist/utils/themecombobox_p.h M +1 -1 messageviewer/a11y/accessiblemailwebview.h M +1 -1 messageviewer/a11y/messagevieweraccessiblewidgetfactory.h M +1 -1 messageviewer/configurewidget.h M +1 -1 messageviewer/csshelper.h M +1 -1 messageviewer/csshelperbase.h M +1 -1 messageviewer/filehtmlwriter.h M +1 -1 messageviewer/findbar/findbarmailwebview.h M +1 -1 messageviewer/findbar/findbarsourceview.h M +1 -1 messageviewer/invitationsettings.h M +1 -1 messageviewer/kcursorsaver.h M +1 -1 messageviewer/kleojobexecutor.h M +1 -1 messageviewer/mailsourceviewer.h M +1 -1 messageviewer/markmessagereadhandler.h M +1 -1 messageviewer/mimetreemodel.h M +1 -1 messageviewer/objecttreeviewersource.h M +1 -1 mobile/mail/composerautoresizer.h M +1 -1 mobile/mail/cryptoformatselectiondialog.h M +1 -1 mobile/mail/filtereditor.h M +1 -1 mobile/mail/messagelistsettingscontroller.h http://commits.kde.org/kdepim/5b1a43ffab4bd5ef491a5bb3492e3a5c086aa552 diff --git a/blogilo/src/bilbopost.h b/blogilo/src/bilbopost.h index 51f4de1..75895a6 100644 --- a/blogilo/src/bilbopost.h +++ b/blogilo/src/bilbopost.h @@ -45,7 +45,7 @@ public: // Published=3D0, Draft, Local // }; BilboPost(); - BilboPost( const KBlog::BlogPost& ); + explicit BilboPost( const KBlog::BlogPost& ); BilboPost( const BilboPost& ); ~BilboPost(); = diff --git a/calendarsupport/incidenceattachmentmodel.h b/calendarsupport/i= ncidenceattachmentmodel.h index 388f40c..a14b715 100644 --- a/calendarsupport/incidenceattachmentmodel.h +++ b/calendarsupport/incidenceattachmentmodel.h @@ -58,7 +58,7 @@ class CALENDARSUPPORT_EXPORT IncidenceAttachmentModel : p= ublic QAbstractListMode = explicit IncidenceAttachmentModel( const Akonadi::Item &item, QObject = *parent =3D 0 ); = - IncidenceAttachmentModel( QObject *parent =3D 0 ); + explicit IncidenceAttachmentModel( QObject *parent =3D 0 ); = ~IncidenceAttachmentModel(); = diff --git a/calendarsupport/next/incidenceviewer.h b/calendarsupport/next/= incidenceviewer.h index ae7f07c..7f2f107 100644 --- a/calendarsupport/next/incidenceviewer.h +++ b/calendarsupport/next/incidenceviewer.h @@ -77,7 +77,7 @@ class CALENDARSUPPORT_EXPORT IncidenceViewer : public QWi= dget, public Akonadi::I * *param * @param parent it the parent widget. */ - IncidenceViewer( QWidget *parent =3D 0 ); + explicit IncidenceViewer( QWidget *parent =3D 0 ); = /** * Destroys the incidence viewer. diff --git a/knode/kscoring.h b/knode/kscoring.h index 4bc0db4..6deaff5 100644 --- a/knode/kscoring.h +++ b/knode/kscoring.h @@ -138,7 +138,7 @@ class KNODE_EXPORT ActionSetScore : public ActionBase { = class KNODE_EXPORT ActionNotify : public ActionBase { public: - ActionNotify( const QString & ); + explicit ActionNotify( const QString & ); ActionNotify( const ActionNotify & ); virtual ~ActionNotify() {} virtual QString toString() const; diff --git a/korganizer/kocheckableproxymodel.h b/korganizer/kocheckablepro= xymodel.h index 550a4cb..e76f7db 100644 --- a/korganizer/kocheckableproxymodel.h +++ b/korganizer/kocheckableproxymodel.h @@ -38,7 +38,7 @@ class KOCheckableProxyModel : public KCheckableProxyModel { Q_OBJECT public: - KOCheckableProxyModel( QObject *parent ); + explicit KOCheckableProxyModel( QObject *parent ); = /**reimp*/ bool setData( const QModelIndex &index, const QVariant &value, diff --git a/messagecore/attachmentfromfolderjob.h b/messagecore/attachment= fromfolderjob.h index 594a271..0d8f77e 100644 --- a/messagecore/attachmentfromfolderjob.h +++ b/messagecore/attachmentfromfolderjob.h @@ -44,7 +44,7 @@ class MESSAGECORE_EXPORT AttachmentFromFolderJob : public= AttachmentFromUrlBaseJ * @param parent The parent object. */ = - AttachmentFromFolderJob( const KUrl &url =3D KUrl(), QObject *parent = =3D 0 ); + explicit AttachmentFromFolderJob( const KUrl &url =3D KUrl(), QObject = *parent =3D 0 ); = /** * Destroys the job. diff --git a/messagecore/attachmentfromurlbasejob.h b/messagecore/attachmen= tfromurlbasejob.h index 2c81dae..f77ed00 100644 --- a/messagecore/attachmentfromurlbasejob.h +++ b/messagecore/attachmentfromurlbasejob.h @@ -33,7 +33,7 @@ class MESSAGECORE_EXPORT AttachmentFromUrlBaseJob : publi= c AttachmentLoadJob Q_OBJECT = public: - AttachmentFromUrlBaseJob( const KUrl &url =3D KUrl(), QObject *parent = =3D 0 ); + explicit AttachmentFromUrlBaseJob( const KUrl &url =3D KUrl(), QObject= *parent =3D 0 ); virtual ~AttachmentFromUrlBaseJob(); = /** diff --git a/messagelist/core/item_p.h b/messagelist/core/item_p.h index 649d499..2419be1 100644 --- a/messagelist/core/item_p.h +++ b/messagelist/core/item_p.h @@ -41,7 +41,7 @@ namespace Core class ItemPrivate { public: - ItemPrivate( Item *owner ) + explicit ItemPrivate( Item *owner ) : q( owner ), mChildItems( 0 ), mParent( 0 ), diff --git a/messagelist/core/messageitem_p.h b/messagelist/core/messageite= m_p.h index d293f12..a8b339c 100644 --- a/messagelist/core/messageitem_p.h +++ b/messagelist/core/messageitem_p.h @@ -34,7 +34,7 @@ class MessageItemPrivate : public ItemPrivate { public: = - MessageItemPrivate( MessageItem *qq ); + explicit MessageItemPrivate( MessageItem *qq ); ~MessageItemPrivate(); = /** diff --git a/messagelist/core/model.h b/messagelist/core/model.h index b87208f..585fd07 100644 --- a/messagelist/core/model.h +++ b/messagelist/core/model.h @@ -85,7 +85,7 @@ public: /** * Creates the mighty Model attached to the specified View. */ - Model( View *pParent ); + explicit Model( View *pParent ); = /** * Destroys the mighty model along with the tree of items it manages. diff --git a/messagelist/core/modelinvariantrowmapper_p.h b/messagelist/cor= e/modelinvariantrowmapper_p.h index 24359c2..34d411f 100644 --- a/messagelist/core/modelinvariantrowmapper_p.h +++ b/messagelist/core/modelinvariantrowmapper_p.h @@ -37,7 +37,7 @@ namespace Core class ModelInvariantRowMapperPrivate { public: - ModelInvariantRowMapperPrivate( ModelInvariantRowMapper *owner ) : q( ow= ner ) { } + explicit ModelInvariantRowMapperPrivate( ModelInvariantRowMapper *owner = ) : q( owner ) { } = /** * Internal. Don't look a this :) diff --git a/messagelist/utils/aggregationcombobox_p.h b/messagelist/utils/= aggregationcombobox_p.h index a217c30..0c35a8f 100644 --- a/messagelist/utils/aggregationcombobox_p.h +++ b/messagelist/utils/aggregationcombobox_p.h @@ -38,7 +38,7 @@ class AggregationComboBox; class AggregationComboBoxPrivate { public: - AggregationComboBoxPrivate( AggregationComboBox *owner ) + explicit AggregationComboBoxPrivate( AggregationComboBox *owner ) : q( owner ) { } = AggregationComboBox * const q; diff --git a/messagelist/utils/themecombobox_p.h b/messagelist/utils/themec= ombobox_p.h index 642fa33..8297652 100644 --- a/messagelist/utils/themecombobox_p.h +++ b/messagelist/utils/themecombobox_p.h @@ -38,7 +38,7 @@ class ThemeComboBox; class ThemeComboBoxPrivate { public: - ThemeComboBoxPrivate( ThemeComboBox *owner ) + explicit ThemeComboBoxPrivate( ThemeComboBox *owner ) : q( owner ) { } = ThemeComboBox * const q; diff --git a/messageviewer/a11y/accessiblemailwebview.h b/messageviewer/a11= y/accessiblemailwebview.h index 5558551..61eed87 100644 --- a/messageviewer/a11y/accessiblemailwebview.h +++ b/messageviewer/a11y/accessiblemailwebview.h @@ -30,7 +30,7 @@ class AccessibleMailWebView: public QAccessibleWidgetEx, { Q_ACCESSIBLE_OBJECT public: - AccessibleMailWebView( MessageViewer::MailWebView *widget ); + explicit AccessibleMailWebView( MessageViewer::MailWebView *widget ); = virtual int characterCount(); = diff --git a/messageviewer/a11y/messagevieweraccessiblewidgetfactory.h b/me= ssageviewer/a11y/messagevieweraccessiblewidgetfactory.h index 8c0a8f4..a7dc5d2 100644 --- a/messageviewer/a11y/messagevieweraccessiblewidgetfactory.h +++ b/messageviewer/a11y/messagevieweraccessiblewidgetfactory.h @@ -23,7 +23,7 @@ = class MessageViewerAccessibleWidgetFactory: public QAccessiblePlugin { public: - MessageViewerAccessibleWidgetFactory( QObject *parent =3D 0 ); + explicit MessageViewerAccessibleWidgetFactory( QObject *parent =3D 0 ); virtual QAccessibleInterface *create( const QString &key, QObject *objec= t ); virtual QStringList keys() const; }; diff --git a/messageviewer/configurewidget.h b/messageviewer/configurewidge= t.h index 40aaaf2..24dfc17 100644 --- a/messageviewer/configurewidget.h +++ b/messageviewer/configurewidget.h @@ -38,7 +38,7 @@ class MESSAGEVIEWER_EXPORT ConfigureWidget : public QWidg= et { Q_OBJECT public: - ConfigureWidget( QWidget *parent =3D 0 ); + explicit ConfigureWidget( QWidget *parent =3D 0 ); = ~ConfigureWidget(); = diff --git a/messageviewer/csshelper.h b/messageviewer/csshelper.h index 313c6f7..fd7b35f 100644 --- a/messageviewer/csshelper.h +++ b/messageviewer/csshelper.h @@ -41,7 +41,7 @@ namespace MessageViewer { class MESSAGEVIEWER_EXPORT CSSHelper : public CSSHelperBase { public: - CSSHelper( const QPaintDevice *pd ); + explicit CSSHelper( const QPaintDevice *pd ); = /** @return HTML head including style sheet definitions and the >body< tag */ diff --git a/messageviewer/csshelperbase.h b/messageviewer/csshelperbase.h index 9e6dd0a..610d649 100644 --- a/messageviewer/csshelperbase.h +++ b/messageviewer/csshelperbase.h @@ -47,7 +47,7 @@ class MESSAGEVIEWER_EXPORT CSSHelperBase { default values. Sub-Classes should put their config loading here. */ - CSSHelperBase( const QPaintDevice *pd ); + explicit CSSHelperBase( const QPaintDevice *pd ); = /** @return HTML head including style sheet definitions and the >body< tag */ diff --git a/messageviewer/filehtmlwriter.h b/messageviewer/filehtmlwriter.h index 561495f..ac2480f 100644 --- a/messageviewer/filehtmlwriter.h +++ b/messageviewer/filehtmlwriter.h @@ -44,7 +44,7 @@ namespace MessageViewer { = class MESSAGEVIEWER_EXPORT FileHtmlWriter : public HtmlWriter { public: - FileHtmlWriter( const QString & filename ); + explicit FileHtmlWriter( const QString & filename ); virtual ~FileHtmlWriter(); = void begin( const QString & cssDefs ); diff --git a/messageviewer/findbar/findbarmailwebview.h b/messageviewer/fin= dbar/findbarmailwebview.h index de6a2c1..c6e83a6 100644 --- a/messageviewer/findbar/findbarmailwebview.h +++ b/messageviewer/findbar/findbarmailwebview.h @@ -41,7 +41,7 @@ class FindBarMailWebView : public FindBarBase virtual ~FindBarMailWebView(); = private: - FindBarMailWebView( QWidget *parent) { Q_UNUSED(parent); } + explicit FindBarMailWebView( QWidget *parent) { Q_UNUSED(parent); } void clearSelections(); void searchText( bool backward, bool isAutoSearch ); void updateHighLight(bool); diff --git a/messageviewer/findbar/findbarsourceview.h b/messageviewer/find= bar/findbarsourceview.h index 7930b77..8eb028f 100644 --- a/messageviewer/findbar/findbarsourceview.h +++ b/messageviewer/findbar/findbarsourceview.h @@ -33,7 +33,7 @@ class FindBarSourceView : public FindBarBase virtual ~FindBarSourceView(); = private: - FindBarSourceView( QWidget *parent) { Q_UNUSED(parent); } + explicit FindBarSourceView( QWidget *parent) { Q_UNUSED(parent); } void clearSelections(); void searchText( bool backward, bool isAutoSearch ); void updateHighLight(bool); diff --git a/messageviewer/invitationsettings.h b/messageviewer/invitations= ettings.h index b92ddfd..c23d32c 100644 --- a/messageviewer/invitationsettings.h +++ b/messageviewer/invitationsettings.h @@ -40,7 +40,7 @@ class MESSAGEVIEWER_EXPORT InvitationSettings : public Q= Widget { Q_OBJECT public: - InvitationSettings( QWidget * parent=3D0 ); + explicit InvitationSettings( QWidget * parent=3D0 ); ~InvitationSettings(); /*reimp*/ void save(); QString helpAnchor() const; diff --git a/messageviewer/kcursorsaver.h b/messageviewer/kcursorsaver.h index 75bb802..463ff07 100644 --- a/messageviewer/kcursorsaver.h +++ b/messageviewer/kcursorsaver.h @@ -17,7 +17,7 @@ class KCursorSaver { public: /// constructor taking QCursor shapes - KCursorSaver(Qt::CursorShape shape) { + explicit KCursorSaver(Qt::CursorShape shape) { QApplication::setOverrideCursor( QCursor(shape) ); inited =3D true; } diff --git a/messageviewer/kleojobexecutor.h b/messageviewer/kleojobexecuto= r.h index 300b885..52ec5ca 100644 --- a/messageviewer/kleojobexecutor.h +++ b/messageviewer/kleojobexecutor.h @@ -45,7 +45,7 @@ class KleoJobExecutor : public QObject { Q_OBJECT public: - KleoJobExecutor( QObject *parent =3D 0 ); + explicit KleoJobExecutor( QObject *parent =3D 0 ); = GpgME::VerificationResult exec( Kleo::VerifyDetachedJob* job, const QByteArray &signature, diff --git a/messageviewer/mailsourceviewer.h b/messageviewer/mailsourcevie= wer.h index ab93c5b..b30240b 100644 --- a/messageviewer/mailsourceviewer.h +++ b/messageviewer/mailsourceviewer.h @@ -54,7 +54,7 @@ class MailSourceViewTextBrowser; class MailSourceHighlighter : public QSyntaxHighlighter { public: - MailSourceHighlighter( QTextDocument * textdocument ) + explicit MailSourceHighlighter( QTextDocument * textdocument ) : QSyntaxHighlighter( textdocument ) {} protected: diff --git a/messageviewer/markmessagereadhandler.h b/messageviewer/markmes= sagereadhandler.h index a4c202b..d9fb9c2 100644 --- a/messageviewer/markmessagereadhandler.h +++ b/messageviewer/markmessagereadhandler.h @@ -43,7 +43,7 @@ class MESSAGEVIEWER_EXPORT MarkMessageReadHandler : publi= c QObject, public Abstr * * @param parent The parent object. */ - MarkMessageReadHandler( QObject *parent =3D 0 ); + explicit MarkMessageReadHandler( QObject *parent =3D 0 ); = /** * Destroys the mark message read handler. diff --git a/messageviewer/mimetreemodel.h b/messageviewer/mimetreemodel.h index f1842c2..a011b45 100644 --- a/messageviewer/mimetreemodel.h +++ b/messageviewer/mimetreemodel.h @@ -44,7 +44,7 @@ class MimeTreeModel : public QAbstractItemModel AlternativeBodyPartRole, UserRole =3D Qt::UserRole + 100 }; - MimeTreeModel( QObject *parent =3D 0 ); + explicit MimeTreeModel( QObject *parent =3D 0 ); ~MimeTreeModel(); = void setRoot( KMime::Content *root ); diff --git a/messageviewer/objecttreeviewersource.h b/messageviewer/objectt= reeviewersource.h index 6eb7900..8078e23 100644 --- a/messageviewer/objecttreeviewersource.h +++ b/messageviewer/objecttreeviewersource.h @@ -31,7 +31,7 @@ class ViewerPrivate; /** An ObjectTreeParser source working on a MailViewer object */ class MailViewerSource : public ObjectTreeSourceIf { public: - MailViewerSource( ViewerPrivate * viewer); + explicit MailViewerSource( ViewerPrivate * viewer); ~MailViewerSource(); bool htmlMail(); bool decryptMessage(); diff --git a/mobile/mail/composerautoresizer.h b/mobile/mail/composerautore= sizer.h index f1a2e6e..cce5606 100644 --- a/mobile/mail/composerautoresizer.h +++ b/mobile/mail/composerautoresizer.h @@ -29,7 +29,7 @@ class ComposerAutoResizer : public QObject Q_OBJECT = public: - ComposerAutoResizer( QTextEdit *parent ); + explicit ComposerAutoResizer( QTextEdit *parent ); = QDeclarativeItem *findFlickable( QGraphicsItem *parent ) const; = diff --git a/mobile/mail/cryptoformatselectiondialog.h b/mobile/mail/crypto= formatselectiondialog.h index 092b239..1601ec4 100644 --- a/mobile/mail/cryptoformatselectiondialog.h +++ b/mobile/mail/cryptoformatselectiondialog.h @@ -42,7 +42,7 @@ class CryptoFormatSelectionDialog : public KDialog * * @param parent The parent widget. */ - CryptoFormatSelectionDialog( QWidget *parent =3D 0 ); + explicit CryptoFormatSelectionDialog( QWidget *parent =3D 0 ); = /** * Destroys the crypto format selection dialog. diff --git a/mobile/mail/filtereditor.h b/mobile/mail/filtereditor.h index 81406c9..b0d6722 100644 --- a/mobile/mail/filtereditor.h +++ b/mobile/mail/filtereditor.h @@ -50,7 +50,7 @@ class FilterEditor : public QObject * actions (e.g. add, edit, delete) at * @param parent The parent object. */ - FilterEditor( KActionCollection *actionCollection, QObject *parent =3D= 0 ); + explicit FilterEditor( KActionCollection *actionCollection, QObject *p= arent =3D 0 ); = public Q_SLOTS: /** diff --git a/mobile/mail/messagelistsettingscontroller.h b/mobile/mail/mess= agelistsettingscontroller.h index cda0be3..b32a4f6 100644 --- a/mobile/mail/messagelistsettingscontroller.h +++ b/mobile/mail/messagelistsettingscontroller.h @@ -38,7 +38,7 @@ class MessageListSettingsController : public QObject Q_PROPERTY( QAction* editAction READ editAction ) = public: - MessageListSettingsController( QObject *parent =3D 0 ); + explicit MessageListSettingsController( QObject *parent =3D 0 ); = QString groupingRole() const; =20