From kde-commits  Mon Dec 24 11:36:19 2012
From: Bart Cerneels <bart.cerneels () kde ! org>
Date: Mon, 24 Dec 2012 11:36:19 +0000
To: kde-commits
Subject: [amarok] src/browsers/playlistbrowser: The correct edit() was not called, lacked polymorphism.
Message-Id: <20121224113619.95E26A60C6 () git ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-commits&m=135634899320587

Git commit e1cad5e80f8f40b08c0c46d85afe0450db2c497c by Bart Cerneels.
Committed on 24/12/2012 at 12:33.
Pushed by shanachie into branch 'master'.

The correct edit() was not called, lacked polymorphism.

CCBUG: 308703

M  +1    -0    src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp
M  +2    -1    src/browsers/playlistbrowser/PlaylistBrowserCategory.h

http://commits.kde.org/amarok/e1cad5e80f8f40b08c0c46d85afe0450db2c497c

diff --git a/src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp b/src=
/browsers/playlistbrowser/PlaylistBrowserCategory.cpp
index f6f06d6..b2f449c 100644
--- a/src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp
+++ b/src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp
@@ -289,6 +289,7 @@ PlaylistBrowserCategory::createNewFolder()
     }
     QModelIndex idx =3D m_filterProxy->mapFromSource( m_byFolderProxy->cre=
ateNewFolder( groupName ) );
     m_playlistView->setCurrentIndex( idx );
+    //edit will fail: https://bugreports.qt-project.org/browse/QTBUG-26838
     m_playlistView->edit( idx );
 }
 =

diff --git a/src/browsers/playlistbrowser/PlaylistBrowserCategory.h b/src/b=
rowsers/playlistbrowser/PlaylistBrowserCategory.h
index 24bdc83..66b3233 100644
--- a/src/browsers/playlistbrowser/PlaylistBrowserCategory.h
+++ b/src/browsers/playlistbrowser/PlaylistBrowserCategory.h
@@ -41,6 +41,7 @@ namespace Playlists {
 namespace PlaylistBrowserNS {
 =

 class PlaylistBrowserModel;
+class PlaylistBrowserView;
 =

 class PlaylistBrowserCategory : public BrowserCategory
 {
@@ -87,7 +88,7 @@ private:
     KActionMenu *m_providerMenu;
     QMap<const Playlists::PlaylistProvider *, QAction *> m_providerActions;
 =

-    QTreeView *m_playlistView;
+    PlaylistBrowserView *m_playlistView;
 =

     KAction *m_addFolderAction;
=20