[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: Re: [kcm-grub2] src: Clarify ambiguous string.
From: Marek Laane <bald () smail ! ee>
Date: 2012-12-23 15:52:09
Message-ID: CAC0LJT_geJHeefgO+GCwSc4SL6JDQMPM8sMEn61qVuHaBg7Big () mail ! gmail ! com
[Download RAW message or body]
2012/12/23 Konstantinos Smanis <konstantinos.smanis@gmail.com>
> On Sun, Dec 23, 2012 at 3:47 PM, Marek Laane <bald@smail.ee> wrote:
> >
> > 2012/12/23 Konstantinos Smanis <konstantinos.smanis@gmail.com>
> >>
> >> Git commit b334e7877058d4602a13e630a3014eba03263518 by Konstantinos
> >> Smanis.
> >> Committed on 23/12/2012 at 14:25.
> >> Pushed by ksmanis into branch 'master'.
> >>
> >> Clarify ambiguous string.
> >>
> >> Small context clarification.
> >>
> >> M +3 -3 src/kcm_grub2.cpp
> >>
> >>
> http://commits.kde.org/kcm-grub2/b334e7877058d4602a13e630a3014eba03263518
> >>
> >> diff --git a/src/kcm_grub2.cpp b/src/kcm_grub2.cpp
> >> index 223fb2b..ca8b2f1 100644
> >> --- a/src/kcm_grub2.cpp
> >> +++ b/src/kcm_grub2.cpp
> >> @@ -790,19 +790,19 @@ void KCMGRUB2::setupObjects()
> >> ui.kpushbutton_terminalSuggestions->setMenu(new
> >> KMenu(ui.kpushbutton_terminalSuggestions));
> >>
> >>
> ui.kpushbutton_terminalSuggestions->menu()->addAction(i18nc("@action:inmenu",
> >> "PC BIOS && EFI Console"))->setData("console");
> >>
> >>
> ui.kpushbutton_terminalSuggestions->menu()->addAction(i18nc("@action:inmenu",
> >> "Serial Terminal"))->setData("serial");
> >> -
> >>
> ui.kpushbutton_terminalSuggestions->menu()->addAction(i18nc("@action:inmenu",
> >> "Open Firmware Console"))->setData("ofconsole");
> >> +
> >>
> ui.kpushbutton_terminalSuggestions->menu()->addAction(i18nc("@action:inmenu
> >> 'Open' is an adjective, not a verb.", "Open Firmware
> >> Console"))->setData("ofconsole");
> >>
> >> ui.kpushbutton_terminalInputSuggestions->setIcon(KIcon("tools-wizard"));
> >> ui.kpushbutton_terminalInputSuggestions->setMenu(new
> >> KMenu(ui.kpushbutton_terminalInputSuggestions));
> >>
> >>
> ui.kpushbutton_terminalInputSuggestions->menu()->addAction(i18nc("@action:inmenu",
> >> "PC BIOS && EFI Console"))->setData("console");
> >>
> >>
> ui.kpushbutton_terminalInputSuggestions->menu()->addAction(i18nc("@action:inmenu",
> >> "Serial Terminal"))->setData("serial");
> >> -
> >>
> ui.kpushbutton_terminalInputSuggestions->menu()->addAction(i18nc("@action:inmenu",
> >> "Open Firmware Console"))->setData("ofconsole");
> >> +
> >>
> ui.kpushbutton_terminalInputSuggestions->menu()->addAction(i18nc("@action:inmenu
> >> 'Open' is an adjective, not a verb.", "Open Firmware
> >> Console"))->setData("ofconsole");
> >>
> >>
> ui.kpushbutton_terminalInputSuggestions->menu()->addAction(i18nc("@action:inmenu",
> >> "PC AT Keyboard (Coreboot)"))->setData("at_keyboard");
> >>
> >>
> ui.kpushbutton_terminalInputSuggestions->menu()->addAction(i18nc("@action:inmenu",
> >> "USB Keyboard (HID Boot Protocol)"))->setData("usb_keyboard");
> >>
> >>
> ui.kpushbutton_terminalOutputSuggestions->setIcon(KIcon("tools-wizard"));
> >> ui.kpushbutton_terminalOutputSuggestions->setMenu(new
> >> KMenu(ui.kpushbutton_terminalOutputSuggestions));
> >>
> >>
> ui.kpushbutton_terminalOutputSuggestions->menu()->addAction(i18nc("@action:inmenu",
> >> "PC BIOS && EFI Console"))->setData("console");
> >>
> >>
> ui.kpushbutton_terminalOutputSuggestions->menu()->addAction(i18nc("@action:inmenu",
> >> "Serial Terminal"))->setData("serial");
> >> -
> >>
> ui.kpushbutton_terminalOutputSuggestions->menu()->addAction(i18nc("@action:inmenu",
> >> "Open Firmware Console"))->setData("ofconsole");
> >> +
> >>
> ui.kpushbutton_terminalOutputSuggestions->menu()->addAction(i18nc("@action:inmenu
> >> 'Open' is an adjective, not a verb.", "Open Firmware
> >> Console"))->setData("ofconsole");
> >>
> >>
> ui.kpushbutton_terminalOutputSuggestions->menu()->addAction(i18nc("@action:inmenu",
> >> "Graphics Mode Output"))->setData("gfxterm");
> >>
> >>
> ui.kpushbutton_terminalOutputSuggestions->menu()->addAction(i18nc("@action:inmenu",
> >> "VGA Text Output (Coreboot)"))->setData("vga_text");
> >> }
> >
> >
> > Is ir right? Isn't "Open Firmware", well, the name?
>
> Sure, what's your point? That it shouldn't be translated?
>
> I just made it clear that this menu item won't open any console.
>
> --
> Konstantinos Smanis
>
That exactly was my point - from the comment one may read out that it is
just an "open firmware", not the "Open Firmware" (or OpenBoot, if to use
its second name). It may depend of language but I guess in most languages
names, as "Open Firmware" IMHO is, are as a rule not translated.
[Attachment #3 (text/html)]
<div class="gmail_extra"><br><br><div class="gmail_quote">2012/12/23 Konstantinos \
Smanis <span dir="ltr"><<a href="mailto:konstantinos.smanis@gmail.com" \
target="_blank">konstantinos.smanis@gmail.com</a>></span><br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> On Sun, Dec 23, 2012 at 3:47 PM, Marek Laane <<a \
href="mailto:bald@smail.ee">bald@smail.ee</a>> wrote:<br> ><br>
> 2012/12/23 Konstantinos Smanis <<a \
href="mailto:konstantinos.smanis@gmail.com">konstantinos.smanis@gmail.com</a>><br> \
>><br> >> Git commit b334e7877058d4602a13e630a3014eba03263518 by \
Konstantinos<br> >> Smanis.<br>
>> Committed on 23/12/2012 at 14:25.<br>
>> Pushed by ksmanis into branch 'master'.<br>
>><br>
>> Clarify ambiguous string.<br>
>><br>
>> Small context clarification.<br>
>><br>
>> M +3 -3 src/kcm_grub2.cpp<br>
>><br>
>> <a href="http://commits.kde.org/kcm-grub2/b334e7877058d4602a13e630a3014eba03263518" \
target="_blank">http://commits.kde.org/kcm-grub2/b334e7877058d4602a13e630a3014eba03263518</a><br>
>><br>
>> diff --git a/src/kcm_grub2.cpp b/src/kcm_grub2.cpp<br>
>> index 223fb2b..ca8b2f1 100644<br>
>> --- a/src/kcm_grub2.cpp<br>
>> +++ b/src/kcm_grub2.cpp<br>
>> @@ -790,19 +790,19 @@ void KCMGRUB2::setupObjects()<br>
>> ui.kpushbutton_terminalSuggestions->setMenu(new<br>
>> KMenu(ui.kpushbutton_terminalSuggestions));<br>
>><br>
>> ui.kpushbutton_terminalSuggestions->menu()->addAction(i18nc("@action:inmenu",<br>
>> "PC BIOS && EFI \
Console"))->setData("console");<br> >><br>
>> ui.kpushbutton_terminalSuggestions->menu()->addAction(i18nc("@action:inmenu",<br>
>> "Serial Terminal"))->setData("serial");<br>
>> -<br>
>> ui.kpushbutton_terminalSuggestions->menu()->addAction(i18nc("@action:inmenu",<br>
>> "Open Firmware Console"))->setData("ofconsole");<br>
>> +<br>
>> ui.kpushbutton_terminalSuggestions->menu()->addAction(i18nc("@action:inmenu<br>
>> 'Open' is an adjective, not a verb.", "Open Firmware<br>
>> Console"))->setData("ofconsole");<br>
>><br>
>> ui.kpushbutton_terminalInputSuggestions->setIcon(KIcon("tools-wizard"));<br>
>> ui.kpushbutton_terminalInputSuggestions->setMenu(new<br>
>> KMenu(ui.kpushbutton_terminalInputSuggestions));<br>
>><br>
>> ui.kpushbutton_terminalInputSuggestions->menu()->addAction(i18nc("@action:inmenu",<br>
>> "PC BIOS && EFI \
Console"))->setData("console");<br> >><br>
>> ui.kpushbutton_terminalInputSuggestions->menu()->addAction(i18nc("@action:inmenu",<br>
>> "Serial Terminal"))->setData("serial");<br>
>> -<br>
>> ui.kpushbutton_terminalInputSuggestions->menu()->addAction(i18nc("@action:inmenu",<br>
>> "Open Firmware Console"))->setData("ofconsole");<br>
>> +<br>
>> ui.kpushbutton_terminalInputSuggestions->menu()->addAction(i18nc("@action:inmenu<br>
>> 'Open' is an adjective, not a verb.", "Open Firmware<br>
>> Console"))->setData("ofconsole");<br>
>><br>
>> ui.kpushbutton_terminalInputSuggestions->menu()->addAction(i18nc("@action:inmenu",<br>
>> "PC AT Keyboard \
(Coreboot)"))->setData("at_keyboard");<br> >><br>
>> ui.kpushbutton_terminalInputSuggestions->menu()->addAction(i18nc("@action:inmenu",<br>
>> "USB Keyboard (HID Boot \
Protocol)"))->setData("usb_keyboard");<br> >><br>
>> ui.kpushbutton_terminalOutputSuggestions->setIcon(KIcon("tools-wizard"));<br>
>> ui.kpushbutton_terminalOutputSuggestions->setMenu(new<br>
>> KMenu(ui.kpushbutton_terminalOutputSuggestions));<br>
>><br>
>> ui.kpushbutton_terminalOutputSuggestions->menu()->addAction(i18nc("@action:inmenu",<br>
>> "PC BIOS && EFI \
Console"))->setData("console");<br> >><br>
>> ui.kpushbutton_terminalOutputSuggestions->menu()->addAction(i18nc("@action:inmenu",<br>
>> "Serial Terminal"))->setData("serial");<br>
>> -<br>
>> ui.kpushbutton_terminalOutputSuggestions->menu()->addAction(i18nc("@action:inmenu",<br>
>> "Open Firmware Console"))->setData("ofconsole");<br>
>> +<br>
>> ui.kpushbutton_terminalOutputSuggestions->menu()->addAction(i18nc("@action:inmenu<br>
>> 'Open' is an adjective, not a verb.", "Open Firmware<br>
>> Console"))->setData("ofconsole");<br>
>><br>
>> ui.kpushbutton_terminalOutputSuggestions->menu()->addAction(i18nc("@action:inmenu",<br>
>> "Graphics Mode Output"))->setData("gfxterm");<br>
>><br>
>> ui.kpushbutton_terminalOutputSuggestions->menu()->addAction(i18nc("@action:inmenu",<br>
>> "VGA Text Output \
(Coreboot)"))->setData("vga_text");<br> >> }<br>
><br>
><br>
> Is ir right? Isn't "Open Firmware", well, the name?<br>
<br>
Sure, what's your point? That it shouldn't be translated?<br>
<br>
I just made it clear that this menu item won't open any console.<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Konstantinos Smanis<br>
</font></span></blockquote></div><br></div><div class="gmail_extra">That exactly was \
my point - from the comment one may read out that it is just an "open \
firmware", not the "Open Firmware" (or OpenBoot, if to use its second \
name). It may depend of language but I guess in most languages names, as "Open \
Firmware" IMHO is, are as a rule not translated.</div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic