[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdelibs/KDE/4.9] solid/solid/backends/udisks: Use correct signature for DriveEject method arguments
From:       Stefan_Brüns <stefan.bruens () rwth-aachen ! de>
Date:       2012-12-15 20:12:30
Message-ID: 20121215201230.A39EFA6091 () git ! kde ! org
[Download RAW message or body]

Git commit af93389d5a821e1c99374aff90f357cc738228d6 by Stefan Brüns.
Committed on 15/12/2012 at 21:11.
Pushed by bruns into branch 'KDE/4.9'.

Use correct signature for DriveEject method arguments

The previous commit added the "unmount" parameter as option for the
DriveEject method. It also inadvertently changed the method signature
of the call from "array of strings" to "string".

DIGEST: Fix ejecting CDs/DVDs when using UDisks backend. UDisks2 is not affected

REVIEW: 107686
BUG: 311613
FIXED-IN: 4.9.5

M  +1    -1    solid/solid/backends/udisks/udisksopticaldrive.cpp

http://commits.kde.org/kdelibs/af93389d5a821e1c99374aff90f357cc738228d6

diff --git a/solid/solid/backends/udisks/udisksopticaldrive.cpp \
b/solid/solid/backends/udisks/udisksopticaldrive.cpp index 8ea6194..8286ee7 100644
--- a/solid/solid/backends/udisks/udisksopticaldrive.cpp
+++ b/solid/solid/backends/udisks/udisksopticaldrive.cpp
@@ -63,7 +63,7 @@ bool UDisksOpticalDrive::eject()
     QString path = m_device->udi();
 
     QDBusMessage msg = QDBusMessage::createMethodCall(UD_DBUS_SERVICE, path, \
                UD_DBUS_INTERFACE_DISKS_DEVICE, "DriveEject");
-    msg << "unmount"; // unmount parameter
+    msg << (QStringList() << "unmount"); // unmount parameter
     return c.callWithCallback(msg, this, SLOT(slotDBusReply(QDBusMessage)), \
SLOT(slotDBusError(QDBusError)));  }
 


[prev in list] [next in list] [prev in thread] [next in thread]