[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdelibs/KDE/4.10] kdecore/services: Don't convert KUrl-QString-QUrl for no reason.
From:       David Faure <faure () kde ! org>
Date:       2012-11-30 23:51:38
Message-ID: 20121130235138.1B4A6A6091 () git ! kde ! org
[Download RAW message or body]

Git commit d389a6588e02a7f69f0dd9c7b7034aa9d5938477 by David Faure.
Committed on 01/12/2012 at 00:51.
Pushed by dfaure into branch 'KDE/4.10'.

Don't convert KUrl-QString-QUrl for no reason.

M  +2    -2    kdecore/services/kmimetype.cpp

http://commits.kde.org/kdelibs/d389a6588e02a7f69f0dd9c7b7034aa9d5938477

diff --git a/kdecore/services/kmimetype.cpp b/kdecore/services/kmimetype.cpp
index adcd6f2..c3d8711 100644
--- a/kdecore/services/kmimetype.cpp
+++ b/kdecore/services/kmimetype.cpp
@@ -501,7 +501,7 @@ QString KMimeType::favIconForUrl( const KUrl& url )
         || !KMimeTypeRepository::self()->useFavIcons())
         return QString();
 
-    QString iconNameFromCache = iconNameCache.value( url.url(), notFound );
+    QString iconNameFromCache = iconNameCache.value(url, notFound);
     if ( iconNameFromCache != notFound ) {
         if ( (++autoClearCache) < 5000 ) {
             return iconNameFromCache;
@@ -516,7 +516,7 @@ QString KMimeType::favIconForUrl( const KUrl& url )
                          QString::fromLatin1("/modules/favicons"),
                          QString::fromLatin1("org.kde.FavIcon") );
     QDBusReply<QString> result = kded.call( QString::fromLatin1("iconForUrl"), url.url() );
-    iconNameCache.insert( url.url(), result.value() );
+    iconNameCache.insert(url, result.value());
     return result;              // default is QString()
 }
 
[prev in list] [next in list] [prev in thread] [next in thread]