[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdelibs/KDE/4.10] solid/solid/backends/udisks2: remove unused code
From:       Lukáš Tinkl <lukas () kde ! org>
Date:       2012-11-06 23:34:48
Message-ID: 20121106233448.3546CA6091 () git ! kde ! org
[Download RAW message or body]

Git commit 33074f96590447ea6a6626835e80bb17d7f09bd5 by Lukáš Tinkl.
Committed on 03/11/2012 at 20:52.
Pushed by lukas into branch 'KDE/4.10'.

remove unused code

M  +0    -31   solid/solid/backends/udisks2/udisksmanager.cpp

http://commits.kde.org/kdelibs/33074f96590447ea6a6626835e80bb17d7f09bd5

diff --git a/solid/solid/backends/udisks2/udisksmanager.cpp \
b/solid/solid/backends/udisks2/udisksmanager.cpp index fab5208..7f9c9b0 100644
--- a/solid/solid/backends/udisks2/udisksmanager.cpp
+++ b/solid/solid/backends/udisks2/udisksmanager.cpp
@@ -129,37 +129,6 @@ QStringList Manager::allDevices()
 {
     m_deviceCache.clear();
 
-#if 0
-    QDBusPendingReply<DBUSManagerStruct> reply = m_manager.GetManagedObjects();
-    reply.waitForFinished();
-    if (!reply.isError()) {  // enum devices
-        m_deviceCache << udiPrefix();
-
-        Q_FOREACH(const QDBusObjectPath &path, reply.value().keys()) {
-            const QString udi = path.path();
-            //qDebug() << "Adding device" << udi;
-
-            if (udi == UD2_DBUS_PATH_MANAGER || udi == UD2_UDI_DISKS_PREFIX || \
                udi.startsWith(UD2_DBUS_PATH_JOBS))
-                continue;
-
-            Device device(udi);
-            if (device.mightBeOpticalDisc()) {
-                QDBusConnection::systemBus().connect(UD2_DBUS_SERVICE, udi, \
                DBUS_INTERFACE_PROPS, "PropertiesChanged", this,
-                                                     \
                SLOT(slotMediaChanged(QDBusMessage)));
-                if (!device.isOpticalDisc())  // skip empty CD disc
-                    continue;
-            }
-
-            m_deviceCache.append(udi);
-        }
-    }
-    else  // show error
-    {
-        qWarning() << "Failed enumerating UDisks2 objects:" << reply.error().name() \
                << "\n" << reply.error().message();
-    }
-
-#endif
-
     introspect("/org/freedesktop/UDisks2/block_devices", true /*checkOptical*/);
     introspect("/org/freedesktop/UDisks2/drives");
 


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic