[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kde-workspace/KDE/4.9] powerdevil/daemon/backends/upower: Improve support for backlight on FreeBSD
From:       Alberto Villa <avilla () FreeBSD ! org>
Date:       2012-10-29 23:45:32
Message-ID: 20121029234532.C53BEA6078 () git ! kde ! org
[Download RAW message or body]

Git commit 408467c4e3c166e829e4bc9204b9c8975a1c8ccd by Alberto Villa.
Committed on 30/10/2012 at 00:41.
Pushed by avilla into branch 'KDE/4.9'.

Improve support for backlight on FreeBSD

LCD screens can appear as any other type when vendors have custom ACPI
implementations. In the future, we hope to standardize non-standard
ACPI-reported devices as "out".

M  +5    -4    powerdevil/daemon/backends/upower/backlighthelper.cpp

http://commits.kde.org/kde-workspace/408467c4e3c166e829e4bc9204b9c8975a1c8ccd

diff --git a/powerdevil/daemon/backends/upower/backlighthelper.cpp \
b/powerdevil/daemon/backends/upower/backlighthelper.cpp index 747a637..2f577a9 100644
--- a/powerdevil/daemon/backends/upower/backlighthelper.cpp
+++ b/powerdevil/daemon/backends/upower/backlighthelper.cpp
@@ -181,12 +181,13 @@ void BacklightHelper::initUsingSysctl()
 {
 #ifdef USE_SYSCTL
     /*
-     * lcd0 would probably be the correct device, but some ACPI implementations \
                can't report it
-     * correctly; thus, an LCD screen can appear as crtN (crt1, in my case). Let's \
                search for the
-     * first device with brightness management, then.
+     * lcd0 is, in theory, the correct device, but some vendors have custom ACPI \
implementations +     * which cannot be interpreted. In that case, devices should be \
reported as "out", but +     * FreeBSD doesn't care (yet), so they can appear as any \
other type. Let's search for the first +     * device with brightness management, \
                then.
      */
     QStringList types;
-    types << "lcd" << "crt";
+    types << "lcd" << "out" << "crt" << "tv" << "ext";
     foreach (const QString &type, types) {
         for (int i = 0; m_sysctlDevice.isEmpty(); i++) {
             QString device = QString("%1%2").arg(type, QString::number(i));


[prev in list] [next in list] [prev in thread] [next in thread]