[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [amarok/spotify] src/core-impl/collections/spotifycollection: Remove all done TODOs
From:       Edward Hades <edward.hades () gmail ! com>
Date:       2012-10-28 11:19:59
Message-ID: 20121028111959.B9047A6100 () git ! kde ! org
[Download RAW message or body]

Git commit 2323d73d6f41201f57bfb1a2a33280402f49f916 by Edward Hades, on behalf of \
Ryan Feng. Committed on 15/08/2012 at 02:12.
Pushed by hades into branch 'spotify'.

Remove all done TODOs

M  +0    -2    src/core-impl/collections/spotifycollection/SpotifyCollection.cpp
M  +1    -1    src/core-impl/collections/spotifycollection/SpotifyPlaylist.cpp
M  +1    -0    src/core-impl/collections/spotifycollection/support/Controller.cpp
M  +0    -5    src/core-impl/collections/spotifycollection/support/Query.cpp

http://commits.kde.org/amarok/2323d73d6f41201f57bfb1a2a33280402f49f916

diff --git a/src/core-impl/collections/spotifycollection/SpotifyCollection.cpp \
b/src/core-impl/collections/spotifycollection/SpotifyCollection.cpp index \
                c624254..60662bd 100644
--- a/src/core-impl/collections/spotifycollection/SpotifyCollection.cpp
+++ b/src/core-impl/collections/spotifycollection/SpotifyCollection.cpp
@@ -276,7 +276,6 @@ namespace Collections
     bool
     SpotifyCollection::hasCapabilityInterface( Capabilities::Capability::Type type ) \
const  {
-        //DONE:TODO: Make this work once capabilities are set.
         switch( type )
         {
             case Capabilities::Capability::Actions :
@@ -289,7 +288,6 @@ namespace Collections
     Capabilities::Capability*
     SpotifyCollection::createCapabilityInterface( Capabilities::Capability::Type \
type )  {
-        //DONE:TODO: Make this work once capabilities are set.
         switch( type )
         {
             case Capabilities::Capability::Actions :
diff --git a/src/core-impl/collections/spotifycollection/SpotifyPlaylist.cpp \
b/src/core-impl/collections/spotifycollection/SpotifyPlaylist.cpp index \
                2a5a048..abdc672 100644
--- a/src/core-impl/collections/spotifycollection/SpotifyPlaylist.cpp
+++ b/src/core-impl/collections/spotifycollection/SpotifyPlaylist.cpp
@@ -28,7 +28,7 @@ SpotifyPlaylist::SpotifyPlaylist( Collections::SpotifyCollection* \
collection, Sp  }
 
 SpotifyPlaylist::SpotifyPlaylist( const QString& name, const Meta::SpotifyTracklist& \
                tracks,
-                                  Collections::SpotifyCollection* collection,, \
SpotifyPlaylistProvider* provider, const sync = true ) +                              \
Collections::SpotifyCollection* collection, SpotifyPlaylistProvider* provider, const \
sync = true )  :QObject( 0 )
 , m_name( name )
 , m_sync( sync )
diff --git a/src/core-impl/collections/spotifycollection/support/Controller.cpp \
b/src/core-impl/collections/spotifycollection/support/Controller.cpp index \
                b530485..f2c41fd 100644
--- a/src/core-impl/collections/spotifycollection/support/Controller.cpp
+++ b/src/core-impl/collections/spotifycollection/support/Controller.cpp
@@ -30,6 +30,7 @@
 #include "core/support/Components.h"
 #include "core/interfaces/Logger.h"
 
+
 #define ShowMessage(x) Amarok::Components::logger()->shortMessage( x )
 
 namespace Spotify
diff --git a/src/core-impl/collections/spotifycollection/support/Query.cpp \
b/src/core-impl/collections/spotifycollection/support/Query.cpp index \
                ef4dd17..259b39c 100644
--- a/src/core-impl/collections/spotifycollection/support/Query.cpp
+++ b/src/core-impl/collections/spotifycollection/support/Query.cpp
@@ -27,13 +27,11 @@ Query::Query( Collections::SpotifyCollection* collection, const \
QString& qid, co  , m_genre( genre )
 , m_collection( collection )
 {
-    //TODO: Connect singals&slots
 }
 
 Query::~Query()
 {
     DEBUG_BLOCK
-    //DONE:TODO: Notify controller to remove current query from map
     emit queryDone( qid() );
 }
 
@@ -99,7 +97,6 @@ Query::tracksAdded( const Meta::SpotifyTrackList& trackList )
 void
 Query::timedOut()
 {
-    //TODO: Abort current query, notify the controller to remove current query from \
                queue
     emit queryError( QueryError ( ETimedOut, QString( "Query(%1) timed out!" ).arg( \
qid() ) ) );  
     // Auto delete self
@@ -111,8 +108,6 @@ Query::timedOut()
 void
 Query::abortQuery()
 {
-    //TODO: Notify the controller to remove the query from queue
-
     emit queryDone( qid() );
 }
 


[prev in list] [next in list] [prev in thread] [next in thread]