[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kde-baseapps] konqueror/settings/kio: SVN_SILENT compile (silent)
From:       Dawit A <adawit () kde ! org>
Date:       2012-10-05 0:15:37
Message-ID: CALa28R7iC2NuNOBGHGZ6kirT=5mv-fbk5nOWFsqXRKQULSmz2w () mail ! gmail ! com
[Download RAW message or body]

Ooops, that change made it into a different commit I did not yet push by
mistake.:( Thanks and yes it is the correct fix.

On Thu, Oct 4, 2012 at 8:01 PM, Christoph Feck <christoph@maxiom.de> wrote:

> Git commit 66ddefe615eaab572e8b8879aad2810346386b25 by Christoph Feck.
> Committed on 05/10/2012 at 01:58.
> Pushed by cfeck into branch 'master'.
>
> SVN_SILENT compile
>
> Thanks for the fast fixes, had to correct this one, please check.
> CCMAIL: adawit@kde.org
>
> M  +1    -1    konqueror/settings/kio/kcookiesmanagement.cpp
>
>
> http://commits.kde.org/kde-baseapps/66ddefe615eaab572e8b8879aad2810346386b25
>
> diff --git a/konqueror/settings/kio/kcookiesmanagement.cpp
> b/konqueror/settings/kio/kcookiesmanagement.cpp
> index 081da39..80b3a62 100644
> --- a/konqueror/settings/kio/kcookiesmanagement.cpp
> +++ b/konqueror/settings/kio/kcookiesmanagement.cpp
> @@ -398,7 +398,7 @@ void
> KCookiesManagement::on_changePolicyButton_clicked()
>      // must be present unless someone rewrote the widget in which case
>      // this needs to be re-written as well.
>      Q_ASSERT(policyDlg);
> -    policyDlg->addNewPolicy(domain);
> +    policyDlg->setPolicy(domain);
>    }
>  }
>
>

[Attachment #3 (text/html)]

Ooops, that change made it into a different commit I did not yet push by mistake.:( \
Thanks and yes it is the correct fix.<br><br><div class="gmail_quote">On Thu, Oct 4, \
2012 at 8:01 PM, Christoph Feck <span dir="ltr">&lt;<a \
href="mailto:christoph@maxiom.de" target="_blank">christoph@maxiom.de</a>&gt;</span> \
wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Git commit 66ddefe615eaab572e8b8879aad2810346386b25 by \
Christoph Feck.<br> Committed on 05/10/2012 at 01:58.<br>
Pushed by cfeck into branch &#39;master&#39;.<br>
<br>
SVN_SILENT compile<br>
<br>
Thanks for the fast fixes, had to correct this one, please check.<br>
CCMAIL: <a href="mailto:adawit@kde.org">adawit@kde.org</a><br>
<br>
M   +1      -1      konqueror/settings/kio/kcookiesmanagement.cpp<br>
<br>
<a href="http://commits.kde.org/kde-baseapps/66ddefe615eaab572e8b8879aad2810346386b25" \
target="_blank">http://commits.kde.org/kde-baseapps/66ddefe615eaab572e8b8879aad2810346386b25</a><br>
 <br>
diff --git a/konqueror/settings/kio/kcookiesmanagement.cpp \
b/konqueror/settings/kio/kcookiesmanagement.cpp<br> index 081da39..80b3a62 100644<br>
--- a/konqueror/settings/kio/kcookiesmanagement.cpp<br>
+++ b/konqueror/settings/kio/kcookiesmanagement.cpp<br>
@@ -398,7 +398,7 @@ void KCookiesManagement::on_changePolicyButton_clicked()<br>
        // must be present unless someone rewrote the widget in which case<br>
        // this needs to be re-written as well.<br>
        Q_ASSERT(policyDlg);<br>
-      policyDlg-&gt;addNewPolicy(domain);<br>
+      policyDlg-&gt;setPolicy(domain);<br>
     }<br>
  }<br>
<br>
</blockquote></div><br>



[prev in list] [next in list] [prev in thread] [next in thread]