[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kde-baseapps/KDE/4.9] konq-plugins/dirfilter: Updated the plugin to use the new KParts extensio
From:       Dawit A <adawit () kde ! org>
Date:       2012-09-27 16:27:49
Message-ID: CALa28R6vnS1GcALVe+t3-WkcmHqDQ38xOV7vZHVWimd-sopn0g () mail ! gmail ! com
[Download RAW message or body]

On Thu, Sep 27, 2012 at 2:22 AM, André Wöbbeking <Woebbeking@kde.org> wrote:

> On Friday 07 September 2012 15:32:30 Dawit Alemayehu wrote:
> > Git commit 14e27dba61bc8d387071b43da8f70d92c4786715 by Dawit Alemayehu.
> > Committed on 03/09/2012 at 23:56.
> > Pushed by adawit into branch 'KDE/4.9'.
> >
> > Updated the plugin to use the new KParts extension,
> > KParts::ListingFilterExtension.
> >
> > M  +1    -1    konq-plugins/dirfilter/CMakeLists.txt
> > M  +181  -217  konq-plugins/dirfilter/dirfilterplugin.cpp
> > M  +24   -26   konq-plugins/dirfilter/dirfilterplugin.h
> >
> >
> http://commits.kde.org/kde-baseapps/14e27dba61bc8d387071b43da8f70d92c4786715
> >
> > diff --git a/konq-plugins/dirfilter/dirfilterplugin.cpp
> > b/konq-plugins/dirfilter/dirfilterplugin.cpp index de766a2..02e1d1f
> 100644
> > --- a/konq-plugins/dirfilter/dirfilterplugin.cpp
> > +++ b/konq-plugins/dirfilter/dirfilterplugin.cpp
> > @@ -165,47 +144,58 @@ DirFilterPlugin::~DirFilterPlugin()
> >
> >  void DirFilterPlugin::slotOpenURL ()
> >  {
> > -  const KUrl url (m_part->url());
> > -
> > -  //kDebug(90190) << "DirFilterPlugin: Current URL: " << m_pURL.url();
> > -
> > -  if (m_pURL != url)
> > -  {
> > -    m_pURL = url;
> > +  Q_ASSERT(m_part);
> > +  m_pFilterMenu->setDisabled(true); // will be enabled after directory
> > filtering is done.
>
> Now I get a crash in Konqueror if I try to open local folders or FTP urls
> as
> m_pFilterMenu isn't initialized.
>

Then you are not using the kdelibs from the 4.9 branch and must have been
compiling kde-baseapps from its 4.9 branch, right ? As a result a version
of the directory filter plugin that did not check for the correct version
of kdelibs was installed on your system (this was the case for a while) and
that is what is causing the crash on your system. IOW, it is not a defect
users will see unless they happen to compile the branch at one specific
point and use older versions of kdelibs. Anyhow, the solution for you here
is to either install kdelibs from the 4.9 branch or remove those older
dirfilterplugin.so, dirfilterplugin.desktop and dirfilterplugin.rc files
from your machine.

[Attachment #3 (text/html)]

On Thu, Sep 27, 2012 at 2:22 AM, André Wöbbeking <span dir="ltr">&lt;<a \
href="mailto:Woebbeking@kde.org" target="_blank">Woebbeking@kde.org</a>&gt;</span> \
wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 \
0 .8ex;border-left:1px #ccc solid;padding-left:1ex">


On Friday 07 September 2012 15:32:30 Dawit Alemayehu wrote:<br>
&gt; Git commit 14e27dba61bc8d387071b43da8f70d92c4786715 by Dawit Alemayehu.<br>
&gt; Committed on 03/09/2012 at 23:56.<br>
&gt; Pushed by adawit into branch &#39;KDE/4.9&#39;.<br>
&gt;<br>
&gt; Updated the plugin to use the new KParts extension,<br>
&gt; KParts::ListingFilterExtension.<br>
&gt;<br>
&gt; M   +1      -1      konq-plugins/dirfilter/CMakeLists.txt<br>
&gt; M   +181   -217   konq-plugins/dirfilter/dirfilterplugin.cpp<br>
&gt; M   +24    -26    konq-plugins/dirfilter/dirfilterplugin.h<br>
&gt;<br>
&gt; <a href="http://commits.kde.org/kde-baseapps/14e27dba61bc8d387071b43da8f70d92c4786715" \
target="_blank">http://commits.kde.org/kde-baseapps/14e27dba61bc8d387071b43da8f70d92c4786715</a><br>
 &gt;<br>
&gt; diff --git a/konq-plugins/dirfilter/dirfilterplugin.cpp<br>
&gt; b/konq-plugins/dirfilter/dirfilterplugin.cpp index de766a2..02e1d1f 100644<br>
&gt; --- a/konq-plugins/dirfilter/dirfilterplugin.cpp<br>
&gt; +++ b/konq-plugins/dirfilter/dirfilterplugin.cpp<br>
&gt; @@ -165,47 +144,58 @@ DirFilterPlugin::~DirFilterPlugin()<br>
&gt;<br>
&gt;   void DirFilterPlugin::slotOpenURL ()<br>
&gt;   {<br>
&gt; -   const KUrl url (m_part-&gt;url());<br>
&gt; -<br>
&gt; -   //kDebug(90190) &lt;&lt; &quot;DirFilterPlugin: Current URL: &quot; &lt;&lt; \
m_pURL.url();<br> &gt; -<br>
&gt; -   if (m_pURL != url)<br>
&gt; -   {<br>
&gt; -      m_pURL = url;<br>
&gt; +   Q_ASSERT(m_part);<br>
&gt; +   m_pFilterMenu-&gt;setDisabled(true); // will be enabled after directory<br>
&gt; filtering is done.<br>
<br>
Now I get a crash in Konqueror if I try to open local folders or FTP urls as<br>
m_pFilterMenu isn&#39;t initialized.<br></blockquote><div><br></div><div>Then you are \
not using the kdelibs from the 4.9 branch and must have been compiling kde-baseapps \
from its 4.9 branch, right ? As a result a version of the directory filter plugin \
that did not check for the correct version of kdelibs was installed on your system \
(this was the case for a while) and that is what is causing the crash on your system. \
IOW, it is not a defect users will see unless they happen to compile the branch at \
one specific point and use older versions of kdelibs. Anyhow, the solution for you \
here is to either install kdelibs from the 4.9 branch or remove those older \
dirfilterplugin.so, dirfilterplugin.desktop and dirfilterplugin.rc files from your \
machine.  </div>


</div><br>



[prev in list] [next in list] [prev in thread] [next in thread]