[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdepimlibs] akonadi: Optimize the no-op cases, these filters are expensive.
From:       Till Adam <adam () kde ! org>
Date:       2012-08-25 17:53:08
Message-ID: 20120825175308.9F007A6094 () git ! kde ! org
[Download RAW message or body]

Git commit abe25b34189081b8173aefe2d3836645bc28031a by Till Adam.
Committed on 25/08/2012 at 19:52.
Pushed by tilladam into branch 'master'.

Optimize the no-op cases, these filters are expensive.

M  +5    -0    akonadi/collectiondialog_desktop.cpp

http://commits.kde.org/kdepimlibs/abe25b34189081b8173aefe2d3836645bc28031a

diff --git a/akonadi/collectiondialog_desktop.cpp b/akonadi/collectiondialog_desktop.cpp
index 8c7fb92..967f2ae 100644
--- a/akonadi/collectiondialog_desktop.cpp
+++ b/akonadi/collectiondialog_desktop.cpp
@@ -279,6 +279,9 @@ Akonadi::Collection::List CollectionDialog::selectedCollections() const
 
 void CollectionDialog::setMimeTypeFilter( const QStringList &mimeTypes )
 {
+  if ( mimeTypeFilter() == mimeTypes )
+    return;
+
   d->mMimeTypeFilterModel->clearFilters();
   d->mMimeTypeFilterModel->addMimeTypeFilters( mimeTypes );
 
@@ -296,6 +299,8 @@ QStringList CollectionDialog::mimeTypeFilter() const
 
 void CollectionDialog::setAccessRightsFilter( Collection::Rights rights )
 {
+  if ( accessRightsFilter() == rights )
+    return;
   d->mRightsFilterModel->setAccessRights( rights );
 }
 
[prev in list] [next in list] [prev in thread] [next in thread]