[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [nepomuk-core] autotests/test: Fix linking order
From:       Vishesh Handa <handa.vish () gmail ! com>
Date:       2012-08-03 23:26:48
Message-ID: CAOPTMKBUO7op26AYLE20tFw-cLBrvNzPZFSxxx7S76n6X57OwA () mail ! gmail ! com
[Download RAW message or body]

Thanks for the commits.

Next time, could you please commit these to KDE/4.9, and then merge KDE/4.9
into master? Or you can skip the merging step if you want. I generally do
the merges twice a week.

Thanks

On Sat, Aug 4, 2012 at 3:35 AM, Andre Heinecke <aheinecke@intevation.de>wrote:

> Git commit be875e2587d0c024b7ca78f9544fa38847b9f419 by Andre Heinecke.
> Committed on 04/08/2012 at 00:03.
> Pushed by aheinecke into branch 'master'.
>
> Fix linking order
>
>     This was necessary for Windows
>
> M  +1    -1    autotests/test/CMakeLists.txt
>
>
> http://commits.kde.org/nepomuk-core/be875e2587d0c024b7ca78f9544fa38847b9f419
>
> diff --git a/autotests/test/CMakeLists.txt b/autotests/test/CMakeLists.txt
> index 43d1f6f..5ce84d4 100644
> --- a/autotests/test/CMakeLists.txt
> +++ b/autotests/test/CMakeLists.txt
> @@ -41,8 +41,8 @@ target_link_libraries(queryupdatetests
>    ${QT_QTGUI_LIBRARY}
>    ${SOPRANO_LIBRARIES}
>    kdecore
> -  nepomukcore
>    nepomuktestlib
> +  nepomukcore
>  )
>
>  add_nepomuk_test(QueryUpdateTests
> ${CMAKE_CURRENT_BINARY_DIR}/queryupdatetests)
>

[Attachment #3 (text/html)]

Thanks for the commits.<br><br>Next time, could you please commit these to KDE/4.9, \
and then merge KDE/4.9 into master? Or you can skip the merging step if you want. I \
generally do the merges twice a week.<br><br>Thanks<br> <br><div \
class="gmail_quote">On Sat, Aug 4, 2012 at 3:35 AM, Andre Heinecke <span \
dir="ltr">&lt;<a href="mailto:aheinecke@intevation.de" \
target="_blank">aheinecke@intevation.de</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Git commit be875e2587d0c024b7ca78f9544fa38847b9f419 by Andre \
Heinecke.<br> Committed on 04/08/2012 at 00:03.<br>
Pushed by aheinecke into branch &#39;master&#39;.<br>
<br>
Fix linking order<br>
<br>
    This was necessary for Windows<br>
<br>
M  +1    -1    autotests/test/CMakeLists.txt<br>
<br>
<a href="http://commits.kde.org/nepomuk-core/be875e2587d0c024b7ca78f9544fa38847b9f419" \
target="_blank">http://commits.kde.org/nepomuk-core/be875e2587d0c024b7ca78f9544fa38847b9f419</a><br>
 <br>
diff --git a/autotests/test/CMakeLists.txt b/autotests/test/CMakeLists.txt<br>
index 43d1f6f..5ce84d4 100644<br>
--- a/autotests/test/CMakeLists.txt<br>
+++ b/autotests/test/CMakeLists.txt<br>
@@ -41,8 +41,8 @@ target_link_libraries(queryupdatetests<br>
   ${QT_QTGUI_LIBRARY}<br>
   ${SOPRANO_LIBRARIES}<br>
   kdecore<br>
-  nepomukcore<br>
   nepomuktestlib<br>
+  nepomukcore<br>
 )<br>
<br>
 add_nepomuk_test(QueryUpdateTests ${CMAKE_CURRENT_BINARY_DIR}/queryupdatetests)<br>
</blockquote></div><br>



[prev in list] [next in list] [prev in thread] [next in thread]