[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [akonadi] server/src/storage: Port to QueryBuilder so this makes use of the prepared query cache.
From:       Volker Krause <vkrause () kde ! org>
Date:       2012-07-13 19:05:54
Message-ID: 20120713190554.A002DA60A6 () git ! kde ! org
[Download RAW message or body]

Git commit 386e144dcd4d6e8997c994acd884f337883ad22e by Volker Krause.
Committed on 13/07/2012 at 19:47.
Pushed by vkrause into branch 'master'.

Port to QueryBuilder so this makes use of the prepared query cache.

M  +6    -15   server/src/storage/entity.cpp

http://commits.kde.org/akonadi/386e144dcd4d6e8997c994acd884f337883ad22e

diff --git a/server/src/storage/entity.cpp b/server/src/storage/entity.cpp
index 5e1007f..6d3f7d8 100644
--- a/server/src/storage/entity.cpp
+++ b/server/src/storage/entity.cpp
@@ -123,22 +123,13 @@ bool Entity::addToRelationImpl( const QString & tableName, const QString & leftC
   if ( !db.isOpen() )
     return false;
 
-  QString statement = QLatin1String("INSERT INTO ");
-  statement.append( tableName );
-  statement.append( QLatin1String(" ( ") );
-  statement.append( leftColumn );
-  statement.append( QLatin1String(" , ") );
-  statement.append( rightColumn );
-  statement.append( QLatin1String(" ) VALUES ( :left, :right )") );
-
-  QSqlQuery query( db );
-  query.prepare( statement );
-  query.bindValue( QLatin1String(":left"), leftId );
-  query.bindValue( QLatin1String(":right"), rightId );
-
-  if ( !query.exec() ) {
+  QueryBuilder qb( tableName, QueryBuilder::Insert );
+  qb.setColumnValue( leftColumn, leftId );
+  qb.setColumnValue( rightColumn, rightId );
+
+  if ( !qb.exec() ) {
     akDebug() << "Error during adding a record to table" << tableName
-             << query.lastError().text();
+             << qb.query().lastError().text();
     return false;
   }
 

[prev in list] [next in list] [prev in thread] [next in thread]