[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kdepim] kalarm: Revert last: Remove X11 requirement
From:       "David Jarvie" <djarvie () kde ! org>
Date:       2012-05-31 17:29:33
Message-ID: 95774101ef2aa47cd910f93c3f573938.squirrel () www ! sensical ! net
[Download RAW message or body]

On Thu, May 31, 2012 5:59 pm, Allen Winter wrote:
> Git commit 26f9d62b9a9b4bfa736b342903d16dc0d8739d98 by Allen Winter.
> Committed on 31/05/2012 at 18:58.
> Pushed by winterz into branch 'master'.
>
> Revert last: Remove X11 requirement
>
> CCMAIL: djarvie@kde.org
> David, without explicit linking to X11 libs, I get an unresolved
> symbol for XSetWMHints

Sorry - the explicit linkage caused a problem for me, and removing it
built ok on my system. But if it doesn't build on all systems, I'll need
to think of a different approach.

> M  +2    -0    kalarm/CMakeLists.txt
>
> http://commits.kde.org/kdepim/26f9d62b9a9b4bfa736b342903d16dc0d8739d98
>
> diff --git a/kalarm/CMakeLists.txt b/kalarm/CMakeLists.txt
> index 9efb9a1..97e69a8 100644
> --- a/kalarm/CMakeLists.txt
> +++ b/kalarm/CMakeLists.txt
> @@ -202,6 +202,7 @@ if(KALARM_USE_AKONADI)
>          kdepim
>          ${KDE4_KCMUTILS_LIBS}
>          ${KDE4_PHONON_LIBS}
> +        ${X11_X11_LIB}
>      )
>  else(KALARM_USE_AKONADI)
>      target_link_libraries(kalarm_bin
> @@ -220,6 +221,7 @@ else(KALARM_USE_AKONADI)
>          kdepim
>          ${KDE4_KCMUTILS_LIBS}
>          ${KDE4_PHONON_LIBS}
> +        ${X11_X11_LIB}
>      )
>  endif(KALARM_USE_AKONADI)


[prev in list] [next in list] [prev in thread] [next in thread]