[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [qtatspi] src: Fix warnings to contain the correct method name.
From:       Sebastian Sauer <mail () dipe ! org>
Date:       2012-05-04 16:31:20
Message-ID: 4FA40458.7030108 () dipe ! org
[Download RAW message or body]

On 05/04/2012 07:25 PM, Lukáš Tinkl wrote:
> Dne 4.5.2012 19:02, Sebastian Sauer napsal(a):
>> Git commit 44c05ef4d00be07d810d54489d53b387228280f7 by Sebastian Sauer.
>> Committed on 04/05/2012 at 17:56.
>> Pushed by sebsauer into branch 'master'.
>>
>> Fix warnings to contain the correct method name.
>>
>> M  +7    -7    src/atspiadaptor.cpp
>>
>> http://commits.kde.org/qtatspi/44c05ef4d00be07d810d54489d53b387228280f7
>>
>> diff --git a/src/atspiadaptor.cpp b/src/atspiadaptor.cpp
>> index 245165a..9dcd521 100644
>> --- a/src/atspiadaptor.cpp
>> +++ b/src/atspiadaptor.cpp
>> @@ -1372,7 +1372,7 @@ bool 
>> AtSpiAdaptor::accessibleInterface(QAccessibleInterface *interface, 
>> int chil
>>           }
>>           
>> connection.send(message.createReply(QVariant::fromValue(children)));
>>       } else {
>> -        qWarning()<<  "WARNING: AtSpiAdaptor::handleMessage does not 
>> implement "<<  function<<  message.path();
>> +        qWarning()<<  "WARNING: AtSpiAdaptor::accessibleInterface 
>> not implement "<<  function<<  message.path();
>
>
> Q_FUNC_INFO is your friend :)

or __FUNCTION__ :) But since it's both used nowhere it would be 
inconsistent. So, someone would need to change all places... not sure if 
that means somebody else would need to solve merge conflicts? Well, I 
leave it up to anybody else to decide and do that :)

-- 
best regards
Sebastian

[prev in list] [next in list] [prev in thread] [next in thread]