[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [calligra] libs/kotext/styles: Add collection to datacenters so images are saved
From:       "C. Boemann" <cbo () boemann ! dk>
Date:       2012-05-01 9:57:20
Message-ID: 201205011157.20118.cbo () boemann ! dk
[Download RAW message or body]

On Tuesday 01 May 2012 07:37:24 Thorsten Zachmann wrote:
> Git commit f80a91d466afd17c773f23bf98adbffe11859d14 by Thorsten Zachmann.
> Committed on 01/05/2012 at 07:32.
> Pushed by zachmann into branch 'master'.
> 
> Add collection to datacenters so images are saved
> 
> If there was no image in the document the image bullets where not saved as
> the image collection was not added to the data centers and therefore the
> images where not saved. This fixes that by adding the image collection to
> the datacenters.

> Reorder the way the attributes are added. They need to be added before a
> child element is added therefore they are moved up.
> Parts of the patch are provided by gopalK.
yay :)
 
> Is it ok to include KoImageData_p.h in a lib of our own code or should we
> find a different solution?
No I wouldn't say it is, so we need to figure out something else

don't we have access to the documentResourceManager?

if so then it holds the ::imageCollection()

> Ok to backport?
Sure it not so bad that we can't backport it like this.

[prev in list] [next in list] [prev in thread] [next in thread]