[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [zanshin] src: Make modeltest pass again.
From:       Christian Mollekopf <chrigi_1 () fastmail ! fm>
Date:       2012-03-27 20:02:23
Message-ID: 20120327200223.7434BA60A9 () git ! kde ! org
[Download RAW message or body]

Git commit a20a93e520e6b20fb68083201a687a43e22d172f by Christian Mollekopf.
Committed on 28/03/2012 at 00:02.
Pushed by cmollekopf into branch 'master'.

Make modeltest pass again.

M  +4    -2    src/todonodemanager.cpp

http://commits.kde.org/zanshin/a20a93e520e6b20fb68083201a687a43e22d172f

diff --git a/src/todonodemanager.cpp b/src/todonodemanager.cpp
index 74a6115..a07cadc 100644
--- a/src/todonodemanager.cpp
+++ b/src/todonodemanager.cpp
@@ -41,8 +41,10 @@ QModelIndex TodoNodeManager::index(int row, int column, =
TodoNode *parent) const
     }
     //We check the following two conditions only in asserts for performanc=
e reasons because they are very expensive in here
     //indexForNode results in nested calls up to the root node and should =
be avoided
-    Q_ASSERT(row < m_model->rowCount(indexForNode(parent, 0)));
-    Q_ASSERT(column < m_model->columnCount(indexForNode(parent, 0)));
+    //The asserts are commented because they break the modeltest. It is sa=
fe to not check here, because rows have already
+    //been checked, and we don't care about columns.
+    //Q_ASSERT(row < m_model->rowCount(indexForNode(parent, 0)));
+    //Q_ASSERT(column < m_model->columnCount(indexForNode(parent, 0)));
 =

     return m_model->createIndex(row, column, parent);
 }
[prev in list] [next in list] [prev in thread] [next in thread]