[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: [kdelibs/frameworks-kcolors] /: Move khbox and kvbox from kdeui/widgets to staging/kwidgets/src/
From: Giorgos Tsiapaliwkas <terietor () gmail ! com>
Date: 2012-03-12 11:10:12
Message-ID: CAODYyLYPjD9sovnmDon-2BhOPJQqfsRL=y5gEi3zMD8YzUxZVA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On 12 March 2012 00:37, David Faure <faure@kde.org> wrote:
> Indeed. Well, we could skip that, of course.
> And when you would rebase, your commit would become only that (the
> addition of
> kwidgets into kcolorwidgets/CMakelists.txt).
I don't understand how this can be done.,
> > In order kcolors to work I have to do a few more splitting.
> > The kcolors can be ready in 2-3 days If there is someone online
> > to help me a bit.
>
> I'll be online.
> I appreciate your optimism ;) But I'm not sure we'll need only 2-3 days,
> this
> seems to drag most of kdeui as dependency, so there are still many things
> to
> solve. But I guess you're right: let's give it a try.
>
in the other thread I mention which files prevent the kcolors from compiling
successfully. It 3-4 files. So when the colors are ready we can merge them.
No?
> BTW for this stuff:
> kcolordialog.cpp: kapp->installX11EventFilter(filter);
> feel free to comment it out for now, like this:
> #if 0 // Qt5 TODO: port to QWidget::nativeEvent
> This will require testing to be ported correctly.
Do you mean this?
s/kapp->installX11EventFilter(filter); / #if 0 // Qt5 TODO: port to
QWidget::nativeEvent
--
Giorgos Tsiapaliwkas (terietor)
KDE Developer
terietor.gr
[Attachment #5 (text/html)]
<div dir="ltr"><br><br><div class="gmail_quote">On 12 March 2012 00:37, David Faure \
<span dir="ltr"><<a href="mailto:faure@kde.org">faure@kde.org</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"> <div class="im">Indeed. Well, we could skip that, of \
course.<br></div> And when you would rebase, your commit would become only that (the \
addition of<br> kwidgets into \
kcolorwidgets/CMakelists.txt).</blockquote><div><br></div><div>I don't understand \
how this can be done.,</div><div> </div><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div \
class="im"> > In order kcolors to work I have to do a few more splitting.<br>
> The kcolors can be ready in 2-3 days If there is someone online<br>
> to help me a bit.<br>
<br>
</div>I'll be online.<br>
I appreciate your optimism ;) But I'm not sure we'll need only 2-3 days, \
this<br> seems to drag most of kdeui as dependency, so there are still many things \
to<br> solve. But I guess you're right: let's give it a \
try.<br></blockquote><div><br></div><div>in the other thread I mention which files \
prevent the kcolors from compiling</div><div>successfully. It 3-4 files. So when the \
colors are ready we can merge them.</div> <div>No?</div><div> </div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> BTW for this stuff:<br>
kcolordialog.cpp: kapp->installX11EventFilter(filter);<br>
feel free to comment it out for now, like this:<br>
#if 0 // Qt5 TODO: port to QWidget::nativeEvent<br>
This will require testing to be ported correctly.</blockquote></div><div><br></div>Do \
you mean this?<div>s/kapp->installX11EventFilter(filter); / #if 0 // Qt5 TODO: \
port to QWidget::nativeEvent <br><br clear="all"><div><br></div>-- <br>Giorgos \
Tsiapaliwkas (terietor)<br>KDE Developer<br><br><a href="http://terietor.gr" \
target="_blank">terietor.gr</a><br> </div></div>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic