[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [muon] /: Filter out foreign-architecture packages that duplicate their native-arch equivalents
From:       Jonathan Thomas <echidnaman () kubuntu ! org>
Date:       2012-02-23 4:21:53
Message-ID: 20120223042153.E8A9AA60A6 () git ! kde ! org
[Download RAW message or body]

Git commit d5e2e95954c31abbe1437e4af63995f1489612a2 by Jonathan Thomas.
Committed on 23/02/2012 at 05:20.
Pushed by jmthomas into branch 'master'.

Filter out foreign-architecture packages that duplicate their native-arch equivalents
(unless they are installed)

todo: make this configurable

M  +1    -0    TODO
M  +4    -0    muon/PackageModel/PackageProxyModel.cpp

http://commits.kde.org/muon/d5e2e95954c31abbe1437e4af63995f1489612a2

diff --git a/TODO b/TODO
index 068fd68..9c832c8 100644
--- a/TODO
+++ b/TODO
@@ -3,6 +3,7 @@ Legend:
  - [MUM] = Muon Update Manager
  - [MSC] = Muon Software Center
 
+-[MPM] Make "show multiarch duplicates" configurable
 -[MPM] Supplemental "slow" search that does a search over package information fields, as opposed to the \
                quick xapian-based search
 -[MPM] Config GUI for confirmation dialogs (save on quit)
 -[MPM] Optional columns for installed and available versions in the Muon Package Manager
diff --git a/muon/PackageModel/PackageProxyModel.cpp b/muon/PackageModel/PackageProxyModel.cpp
index 5b3f97d..d91e785 100644
--- a/muon/PackageModel/PackageProxyModel.cpp
+++ b/muon/PackageModel/PackageProxyModel.cpp
@@ -138,6 +138,10 @@ bool PackageProxyModel::filterAcceptsRow(int sourceRow, const QModelIndex &sourc
         }
     }
 
+    // TODO before 1.4: Configurable
+    if (package->isMultiArchDuplicate())
+        return false;
+
     if (m_sortByRelevancy) {
         return m_packages.contains(package);
     }


[prev in list] [next in list] [prev in thread] [next in thread]