[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kphotoalbum] XMLDB: logic error fixed in file removal
From:       Miika Turkia <miika.turkia () gmail ! com>
Date:       2012-02-22 4:38:16
Message-ID: 20120222043816.EA6A1A60A6 () git ! kde ! org
[Download RAW message or body]

Git commit 788221159463174013d660f805564dfb4d70042c by Miika Turkia.
Committed on 22/02/2012 at 05:37.
Pushed by mturkia into branch 'master'.

logic error fixed in file removal

M  +1    -1    XMLDB/FileWriter.cpp

http://commits.kde.org/kphotoalbum/788221159463174013d660f805564dfb4d70042c

diff --git a/XMLDB/FileWriter.cpp b/XMLDB/FileWriter.cpp
index d266274..d3d6941 100644
--- a/XMLDB/FileWriter.cpp
+++ b/XMLDB/FileWriter.cpp
@@ -89,7 +89,7 @@ void XMLDB::FileWriter::save( const QString& fileName, bo=
ol isAutoSave )
             // State: index.xml has previous DB version, index.xml.tmp has=
 the current version.
 =

             // original file can be safely deleted
-            if ( QFile::exists( fileName ) && ( ! QFile::remove( fileName =
) ) )
+            if ( ( ! QFile::remove( fileName ) ) && QFile::exists( fileNam=
e ) )
             {
                 KMessageBox::sorry( messageParent(),
                         i18n("<p>Failed to remove old version of image dat=
abase.</p>"
[prev in list] [next in list] [prev in thread] [next in thread]