[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo
From:       Lamarque Souza <lamarque () kde ! org>
Date:       2012-02-20 20:55:32
Message-ID: 20120220205532.06745AC895 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1281263 by lvsouza:

Modify the Yahoo login URL to percent encode username and password.
Fixes kopete does not save passwords correctly if it contains symbols
Thanks to Alex Dănilă for this patch.

BUG: 165308


 M  +3 -2      logintask.cpp  


--- trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/logintask.cpp #1281262:1281263
@@ -213,8 +213,9 @@
 	kDebug(YAHOO_RAW_DEBUG) << "seed:" << seed;
 	m_stage1Data.clear();
 	/* construct a URL from the seed and request tokens */
-	QByteArray encodedUrl;
-	QString fullUrl = YahooTokenUrl.arg(sn, client()->password(), seed);
+	QString encodedPassword(QUrl::toPercentEncoding(client()->password()));
+	QString encodedUser(QUrl::toPercentEncoding(sn));
+	QString fullUrl = YahooTokenUrl.arg(encodedUser, encodedPassword, seed);
 	KUrl tokenUrl(fullUrl);
 	KIO::Job* job = KIO::get(tokenUrl, KIO::Reload, KIO::HideProgressInfo);
 	connect(job, SIGNAL(data(KIO::Job*,QByteArray)),
[prev in list] [next in list] [prev in thread] [next in thread]