[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdegames/kpat/libkcardgame
From:       Parker Coates <parker.coates () kdemail ! net>
Date:       2012-02-15 4:45:34
Message-ID: 20120215044534.073B8AC894 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1280176 by coates:

Remove an overly strict assertion from KCardPile::insert().

Since QList::insert() properly prepends with negative indices and
properly appends with indices greater than size(), there's no need for
us to assert the index is within the range of "valid" indices.

 M  +0 -2      kcardpile.cpp  


--- trunk/KDE/kdegames/kpat/libkcardgame/kcardpile.cpp #1280175:1280176
@@ -424,8 +424,6 @@
 
 void KCardPile::insert( KCard * card, int index )
 {
-    Q_ASSERT( 0 <= index && index <= d->cards.size() );
-
     if ( card->scene() != scene() )
         scene()->addItem( card );
 
[prev in list] [next in list] [prev in thread] [next in thread]