[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdepim/KDE/4.8] kmail: Fix value of mIsValid flag
From:       Kevin Krammer <kevin.krammer () gmx ! at>
Date:       2012-02-09 13:53:36
Message-ID: 20120209135336.25016A60A6 () git ! kde ! org
[Download RAW message or body]

Git commit 12d3d44b4a034321b0340623006057bd56df3562 by Kevin Krammer.
Committed on 09/02/2012 at 14:51.
Pushed by krake into branch 'KDE/4.8'.

Fix value of mIsValid flag

mIsValid was reset to true after potentially set to false in error
cases.
Move mIsValid = true to beginning of method so any change to false
stays applied

CCMAIL: montel@kde.org

M  +2    -2    kmail/addressvalidationjob.cpp

http://commits.kde.org/kdepim/12d3d44b4a034321b0340623006057bd56df3562

diff --git a/kmail/addressvalidationjob.cpp b/kmail/addressvalidationjob.cpp
index b557d1b..23f006a 100644
--- a/kmail/addressvalidationjob.cpp
+++ b/kmail/addressvalidationjob.cpp
@@ -50,6 +50,8 @@ class AddressValidationJob::Private
 
 void AddressValidationJob::Private::slotAliasExpansionDone( KJob *job )
 {
+  mIsValid = true;
+
   if ( job->error() ) {
     q->setError( job->error() );
     q->setErrorText( job->errorText() );
@@ -91,8 +93,6 @@ void AddressValidationJob::Private::slotAliasExpansionDone( KJob *job )
     }
   }
 
-  mIsValid = true;
-
   q->emitResult();
 }
 
[prev in list] [next in list] [prev in thread] [next in thread]