'Re: [networkmanagement/nm09] vpnplugins/openvpn: Do what the comment says'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [networkmanagement/nm09] vpnplugins/openvpn: Do what the comment says
From:       "Lamarque V. Souza" <lamarque () kde ! org>
Date:       2012-01-22 16:48:11
Message-ID: 201201221448.11793.lamarque () kde ! org
[Download RAW message or body]

Em Sunday 22 January 2012, Albert Astals Cid escreveu:
> Git commit edc9568628f799e7b1faa9d0ddfa10e3b43b4af9 by Albert Astals Cid.
> Committed on 22/01/2012 at 17:40.
> Pushed by aacid into branch 'nm09'.
> 
> Do what the comment says
> 
> You need a double \\ here because of the compiler espacing
> Want me to forwardport this to master?

	Yes for this change and the other about z-order warning. Next time if 
you want to fix it only in master is Ok too. Thanks.
	
> CCMAIL: lamarque@kde.org
> 
> M  +1    -1    vpnplugins/openvpn/openvpn.cpp
> 
> http://commits.kde.org/networkmanagement/edc9568628f799e7b1faa9d0ddfa10e3b4
> 3b4af9
> 
> diff --git a/vpnplugins/openvpn/openvpn.cpp
> b/vpnplugins/openvpn/openvpn.cpp index 3dc87a7..2d4402f 100644
> --- a/vpnplugins/openvpn/openvpn.cpp
> +++ b/vpnplugins/openvpn/openvpn.cpp
> @@ -96,7 +96,7 @@ QString unQuote(QString &certVal, const QString
> &fileName) }
>      }
>      certFile.replace("\\\\", "\\");     // Replace '\\' with '\'
> -    certFile.replace("\ ", " ");        // Replace escaped space with
> space +    certFile.replace("\\ ", " ");        // Replace escaped space
> with space if (QFileInfo(certFile).isRelative())
>          certFile = QFileInfo(fileName).dir().absolutePath() + '/' +
> certFile; return certFile;


-- 
Lamarque V. Souza
KDE's Network Management maintainer
http://planetkde.org/pt-br

[Attachment #3 (text/html)]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"> <html><head><meta name="qrichtext" \
content="1" /><style type="text/css"> p, li { white-space: pre-wrap; }
</style></head><body style=" font-family:'Tahoma'; font-size:12pt; font-weight:400; \
font-style:normal;"> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Em Sunday \
22 January 2012, Albert Astals Cid escreveu:</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">&gt; Git commit \
edc9568628f799e7b1faa9d0ddfa10e3b43b4af9 by Albert Astals Cid.</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; Committed on 22/01/2012 \
at 17:40.</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; Pushed \
by aacid into branch 'nm09'.</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">&gt; </p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">&gt; Do what the comment says</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">&gt; </p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">&gt; You need a double \\ here because of the \
compiler espacing</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; Want \
me to forwardport this to master?</p> <p style="-qt-paragraph-type:empty; \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; ">&nbsp;</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">	Yes for this change and the other about z-order \
warning. Next time if you want to fix it only in master is Ok too. Thanks.</p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">	</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; CCMAIL: \
lamarque@kde.org</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; </p> \
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; M  +1    -1    \
vpnplugins/openvpn/openvpn.cpp</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">&gt; </p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">&gt; \
http://commits.kde.org/networkmanagement/edc9568628f799e7b1faa9d0ddfa10e3b4</p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; 3b4af9</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; </p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; diff --git \
a/vpnplugins/openvpn/openvpn.cpp</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">&gt; b/vpnplugins/openvpn/openvpn.cpp index 3dc87a7..2d4402f \
100644</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; --- \
a/vpnplugins/openvpn/openvpn.cpp</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">&gt; +++ b/vpnplugins/openvpn/openvpn.cpp</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; @@ -96,7 +96,7 @@ \
QString unQuote(QString &amp;certVal, const QString</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">&gt; &amp;fileName) }</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt;      }</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt;      \
certFile.replace(&quot;\\\\&quot;, &quot;\\&quot;);     // Replace '\\' with '\'</p> \
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; -    \
certFile.replace(&quot;\ &quot;, &quot; &quot;);        // Replace escaped space \
with</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; space \
+    certFile.replace(&quot;\\ &quot;, &quot; &quot;);        // Replace escaped \
space</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; with \
space if (QFileInfo(certFile).isRelative())</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">&gt;          certFile = \
QFileInfo(fileName).dir().absolutePath() + '/' +</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">&gt; certFile; return certFile;</p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">-- </p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Lamarque V. Souza</p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">KDE's Network Management \
maintainer</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">http://planetkde.org/pt-br</p></body></html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic