[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    extragear/multimedia/kmplayer/src
From:       Koos Vriezen <koos.vriezen () gmail ! com>
Date:       2012-01-21 17:13:24
Message-ID: 20120121171324.C02F5AC892 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1275103 by vriezen:

Fix call finish from timing groups deactivate

Which caused a parent group never to receive the child finished message

 M  +2 -1      kmplayer_smil.cpp  


--- trunk/extragear/multimedia/kmplayer/src/kmplayer_smil.cpp #1275102:1275103
@@ -2544,13 +2544,14 @@
 
 
 KDE_NO_EXPORT void SMIL::GroupBase::deactivate () {
+    bool need_finish (unfinished ());
     setState (state_deactivated); // avoid recurstion through childDone
     for (NodePtr e = firstChild (); e; e = e->nextSibling ())
         if (e->active ())
             e->deactivate ();
         else
             e->message (MsgMediaPrefetch, MsgBool (0));
-    if (unfinished ())
+    if (need_finish)
         finish ();
     runtime->init ();
     Element::deactivate ();
[prev in list] [next in list] [prev in thread] [next in thread]