[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdemultimedia/kmix/dbus
From:       Christian Esken <esken () kde ! org>
Date:       2011-12-30 10:40:49
Message-ID: 20111230104049.A23D7AC7DB () svn ! kde ! org
[Download RAW message or body]

SVN commit 1270922 by esken:

comments only

 M  +0 -11     dbuscontrolwrapper.cpp  


--- trunk/KDE/kdemultimedia/kmix/dbus/dbuscontrolwrapper.cpp #1270921:1270922
@@ -56,17 +56,6 @@
 
 void DBusControlWrapper::setVolume(int percentage)
 {
-    // @todo Is hardcoded to PlaybackVolume
-    // @todo This will not work, if minVolume != 0      !!!
-	//       e.g.: minVolume=5 or minVolume=-10
-	// The solution is to check two cases:
-	//     volume < 0 => use minVolume for volumeRange
-	//     volume > 0 => use maxVolume for volumeRange
-	//     If chosen volumeRange==0 => return 0
-	// As this is potentially used often (Sliders, ...), it
-	// should be implemented in the Volume class.
-	// For now we go with "maxVolume()", like in the rest of KMix.
-	//  - esken
 	Volume& volP = m_md->playbackVolume();
 	Volume& volC = m_md->captureVolume();
 	volP.setAllVolumes( volP.minVolume() + ((percentage * volP.volumeSpan()) / 100) );
[prev in list] [next in list] [prev in thread] [next in thread]