[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kwebkitpart] src: I'm not sure about this hack,
From:       Dawit A <adawit () kde ! org>
Date:       2011-12-02 18:36:38
Message-ID: CALa28R6sTxf7_n3bvOCwpu-wsTNWYmSYPk1yjE-PkZi+RCHa=w () mail ! gmail ! com
[Download RAW message or body]

On Wed, Nov 30, 2011 at 10:52 AM, David Faure <faure@kde.org> wrote:
> Git commit ee14cf3fb7ef5d303a94eab27403bab5553870a6 by David Faure.
> Committed on 30/11/2011 at 16:53.
> Pushed by dfaure into branch 'master'.
> 
> I'm not sure about this hack, see <a href="mailto:faure@kde.org">GNARF</a>
> 
> CCMAIL: adawit@kde.org
> 
> M   +1      -0      src/webpage.cpp
> 
> http://commits.kde.org/kwebkitpart/ee14cf3fb7ef5d303a94eab27403bab5553870a6
> 
> diff --git a/src/webpage.cpp b/src/webpage.cpp
> index 5b186df..4c27c8a 100644
> --- a/src/webpage.cpp
> +++ b/src/webpage.cpp
> @@ -728,6 +728,7 @@ static QUrl sanitizeMailToUrl(const QUrl &url, QStringList& \
> files) { while (it.hasNext()) {
> QPair<QString, QString> queryItem = it.next();
> if (queryItem.first.contains(QL1C('@')) && queryItem.second.isEmpty()) {
> +                  // ### DF: this hack breaks mailto:faure@kde.org, kmail doesn't \
> expect mailto:?to=faure@kde.org

Hmm... I do not see that here. I have a similar unit test for that
under kwebkitpart/tests/link_tests.html:

<a href="mailto:joe@xyz.com">Email link #2</a>

When I click on such links, kmail opens with its "TO:" field properly
set to "joe@xyz.com". Under what circumstances did you encounter this
issue ? I even typed the "mailto:" URL into Konqueror's location bar
and got the same correct result.


[prev in list] [next in list] [prev in thread] [next in thread]