[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [ksecrets] /: Fixed krazy issues
From:       Valentin Rusu <kde () rusu ! info>
Date:       2011-10-31 20:36:31
Message-ID: 20111031203631.952E3A60A6 () git ! kde ! org
[Download RAW message or body]

Git commit db7175f75af7e90691e44b7b4412b35db7920006 by Valentin Rusu.
Committed on 31/10/2011 at 21:36.
Pushed by vrusu into branch 'master'.

Fixed krazy issues

M  +2    -2    ksecrets/ksecretsapp.cpp
M  +5    -5    kwl2kss/importsinglewalletjob.cpp
M  +2    -2    secretsync/kcm/addcomputerwidget.ui
M  +13   -2    secretsync/kcm/configwidget.ui
M  +1    -1    secretsync/statuswidget.ui
M  +1    -1    secretsync/syncmodel.cpp

http://commits.kde.org/ksecrets/db7175f75af7e90691e44b7b4412b35db7920006

diff --git a/ksecrets/ksecretsapp.cpp b/ksecrets/ksecretsapp.cpp
index 6bb6ba4..060368a 100644
--- a/ksecrets/ksecretsapp.cpp
+++ b/ksecrets/ksecretsapp.cpp
@@ -80,7 +80,7 @@ void KSecretsApp::slotListCollectionsDone(KJob* job)
 {
     ListCollectionsJob *listJob = qobject_cast< ListCollectionsJob* >(job);
     if ( listJob->error() == 0 ) {
-        foreach( QString collName, listJob->collections() ) {
+        foreach( const QString &collName, listJob->collections() ) {
             cout << collName << endl;
         }
     }
@@ -108,7 +108,7 @@ void KSecretsApp::slotListItemsDone(KJob* job)
         KSecretsAppJob *listItemsJob = new KSecretsAppJob(this);
         connect( listItemsJob, SIGNAL(finished(KJob*)), this, SLOT(slotReadAllItemsDone(KJob*)) );
         
-        foreach( ReadCollectionItemsJob::Item item, listJob->items() ) {
+        foreach( const ReadCollectionItemsJob::Item &item, listJob->items() ) {
             ReadItemPropertyJob *readJob = item->attributes();
             QVariant varItem;
             varItem.setValue< ReadCollectionItemsJob::Item >( item );
diff --git a/kwl2kss/importsinglewalletjob.cpp b/kwl2kss/importsinglewalletjob.cpp
index ab60f9b..f5e6eaf 100644
--- a/kwl2kss/importsinglewalletjob.cpp
+++ b/kwl2kss/importsinglewalletjob.cpp
@@ -20,6 +20,10 @@
  */
 
 
+#include "importsinglewalletjob.h"
+#include "kwalletbackend/kwalletentry.h"
+#include "kwalletbackend/kwalletbackend.h"
+#include <QTimer>
 #include <kpassworddialog.h>
 #include <kwallet.h> // for KSS_ macros
 #include <KLocalizedString>
@@ -34,10 +38,6 @@
 #include <ksecretsservicecollectionjobs.h>
 #include <ksecretsserviceitem.h>
 
-#include "importsinglewalletjob.h"
-#include "kwalletbackend/kwalletentry.h"
-#include "kwalletbackend/kwalletbackend.h"
-#include <QTimer>
 
 using namespace KSecretsService;
 
@@ -218,7 +218,7 @@ void ImportSingleWalletJob::onWalletOpened(bool success)
     
     // count the entries in this wallet, for progress bar needs
     uint amount =0;
-    foreach( const QString folder, m_folderList ) {
+    foreach( const QString &folder, m_folderList ) {
         m_wallet->setFolder( folder );
         amount += m_wallet->entryList().count();
     }
diff --git a/secretsync/kcm/addcomputerwidget.ui b/secretsync/kcm/addcomputerwidget.ui
index 2a2775f..e83df14 100644
--- a/secretsync/kcm/addcomputerwidget.ui
+++ b/secretsync/kcm/addcomputerwidget.ui
@@ -21,7 +21,7 @@
       </widget>
      </item>
      <item>
-      <widget class="QLineEdit" name="_computerName">
+      <widget class="KLineEdit" name="_computerName">
        <property name="toolTip">
         <string>Enter computer name or IP address here</string>
        </property>
@@ -42,7 +42,7 @@
       </widget>
      </item>
      <item>
-      <widget class="QLineEdit" name="_port">
+      <widget class="KLineEdit" name="_port">
        <property name="toolTip">
         <string>Enter remote port number here</string>
        </property>
diff --git a/secretsync/kcm/configwidget.ui b/secretsync/kcm/configwidget.ui
index 5242845..e9be440 100644
--- a/secretsync/kcm/configwidget.ui
+++ b/secretsync/kcm/configwidget.ui
@@ -18,7 +18,7 @@
   </property>
   <layout class="QVBoxLayout" name="verticalLayout_5">
    <item>
-    <widget class="QTabWidget" name="_tabs">
+    <widget class="KTabWidget" name="_tabs">
      <property name="currentIndex">
       <number>0</number>
      </property>
@@ -117,7 +117,7 @@
           </widget>
          </item>
          <item>
-          <widget class="QLineEdit" name="kcfg_listeningPort"/>
+          <widget class="KLineEdit" name="kcfg_listeningPort"/>
          </item>
          <item>
           <spacer name="horizontalSpacer_2">
@@ -239,10 +239,21 @@
  </widget>
  <customwidgets>
   <customwidget>
+   <class>KLineEdit</class>
+   <extends>QLineEdit</extends>
+   <header>klineedit.h</header>
+  </customwidget>
+  <customwidget>
    <class>KIntSpinBox</class>
    <extends>QSpinBox</extends>
    <header>knuminput.h</header>
   </customwidget>
+  <customwidget>
+   <class>KTabWidget</class>
+   <extends>QTabWidget</extends>
+   <header>ktabwidget.h</header>
+   <container>1</container>
+  </customwidget>
  </customwidgets>
  <resources/>
  <connections>
diff --git a/secretsync/statuswidget.ui b/secretsync/statuswidget.ui
index 3b40fb2..2b29c79 100644
--- a/secretsync/statuswidget.ui
+++ b/secretsync/statuswidget.ui
@@ -12,7 +12,7 @@
   </property>
   <layout class="QVBoxLayout" name="verticalLayout_3">
    <item>
-    <widget class="QTabWidget" name="tabWidget">
+    <widget class="KTabWidget" name="tabWidget">
      <property name="currentIndex">
       <number>0</number>
      </property>
diff --git a/secretsync/syncmodel.cpp b/secretsync/syncmodel.cpp
index e2aff50..b7d1c06 100644
--- a/secretsync/syncmodel.cpp
+++ b/secretsync/syncmodel.cpp
@@ -97,7 +97,7 @@ SyncModel::SyncModel() :
     setHorizontalHeaderLabels( horizontalLabels );
 
     if ( KSecretSyncCfg::computerList().count() >0 ) {
-        foreach( QString computerName, KSecretSyncCfg::computerList() ) {
+        foreach( const QString &computerName, KSecretSyncCfg::computerList() ) {
             ComputerData *computerData = new ComputerData( computerName );
             QList< QStandardItem* > itemList;
             itemList.append( new ComputerDataDisplayItem( computerData, 0 ));

[prev in list] [next in list] [prev in thread] [next in thread]