[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [calligra] libs/kotext/styles/tests: Fix the unit test for some
From:       Thorsten Zachmann <t.zachmann () zagge ! de>
Date:       2011-09-01 4:09:00
Message-ID: 201109010609.00488.t.zachmann () zagge ! de
[Download RAW message or body]

On Thursday, September 01, 2011 00:51:04 Pierre Ducroquet wrote:
> --- a/libs/kotext/styles/tests/TestOpenDocumentStyle.cpp
> +++ b/libs/kotext/styles/tests/TestOpenDocumentStyle.cpp
> @@ -39,6 +39,7 @@
>  #include <QBuffer>
>  #include <QDomDocument>
>  #include <QDomElement>
> +#include
> <krita/plugins/extensions/tonemapping/operators/trilateral/memory.h>

The adding of this include looks suspicious. I can't see why it would be 
needed. Please remove.

> +    else if (m_name == "style:border-line-width-left")
> +        m_requiredExtraAttributes["fo:border-left"] = "double";
> +    else if (m_name == "style:border-line-width-right")
> +        m_requiredExtraAttributes["fo:border-right"] = "double";
> +    else if (m_name == "style:border-line-width-top")
> +        m_requiredExtraAttributes["fo:border-top"] = "double";
> +    else if (m_name == "style:border-line-width-bottom")
> +        m_requiredExtraAttributes["fo:border-bottom"] = "double";

It might that only the fo:border is set if that one is the same for all and 
only the border-line-width-... might be different.

Thorsten
[prev in list] [next in list] [prev in thread] [next in thread]