[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kate] part/syntax/data: dd: if does not need extra space before [
From:       Christian Loose <christian.loose () hamburg ! de>
Date:       2011-08-14 10:04:37
Message-ID: 4E479DB5.9080008 () hamburg ! de
[Download RAW message or body]

Am 13.08.2011 21:18, schrieb Dominik Haumann:
> Git commit 0cca7274a050c179b9443247cc89cc139020fc8e by Dominik Haumann.
> Committed on 13/08/2011 at 21:15.
> Pushed by dhaumann into branch 'master'.
> 
> dd: if does not need extra space before [
> 
> CCBUG: 208762
> REVIEW: 102318
> 
> M  +2    -2    part/syntax/data/bash.xml
> 
> http://commits.kde.org/kate/0cca7274a050c179b9443247cc89cc139020fc8e
> 
> diff --git a/part/syntax/data/bash.xml b/part/syntax/data/bash.xml
> index f9f1885..269dcce 100644
> --- a/part/syntax/data/bash.xml
> +++ b/part/syntax/data/bash.xml
> @@ -8,7 +8,7 @@
> <!ENTITY noword   "(?![\w$+-])">                 <!-- no word, $, + or - following \
> --> <!ENTITY pathpart "([\w_@.&#37;*?+-]|\\ )">      <!-- valid character in a file \
> name --> ]>
> -<language name="Bash" version="2.12" kateversion="2.4" section="Scripts" \
> extensions="*.sh;*.bash;*.ebuild;*.eclass;.bashrc;.bash_profile;.bash_login;.profile" \
> mimetype="application/x-shellscript" casesensitive="1" author="Wilbert Berendsen \
> (wilbert@kde.nl)" license="LGPL"> +<language name="Bash" version="2.13" \
> kateversion="2.4" section="Scripts" \
> extensions="*.sh;*.bash;*.ebuild;*.eclass;.bashrc;.bash_profile;.bash_login;.profile" \
> mimetype="application/x-shellscript" casesensitive="1" author="Wilbert Berendsen \
> (wilbert@kde.nl)" license="LGPL"> 
> <!-- (c) 2004 by Wilbert Berendsen (wilbert@kde.nl)
> Changes by Matthew Woehlke (mw_triad@users.sourceforge.net)
> @@ -517,7 +517,7 @@
> <!-- match do and if blocks -->
> <RegExpr attribute="Keyword" context="#stay" String="\bdo&noword;" beginRegion="do" \
> /> <RegExpr attribute="Keyword" context="#stay" String="\bdone&noword;" \
>                 endRegion="do" />
> -<RegExpr attribute="Keyword" context="#stay" String="\bif&noword;" \
> beginRegion="if" /> +<RegExpr attribute="Keyword" context="#stay" \
> String="\bif&noword;" beginRegion="if" />

Hi Dominik,

now we are back to square one and you reintroduced  bug #208762.
What was wrong with my patch in review 102318 (except for the missing 
version change)?

Bye, Christian


[prev in list] [next in list] [prev in thread] [next in thread]