[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [amarok] /: Use QGraphicsScene::NoIndex instead of
From:       Daniel Faust <hessijames () gmail ! com>
Date:       2011-08-08 14:14:08
Message-ID: 20110808141408.589D1A60B4 () git ! kde ! org
[Download RAW message or body]

Git commit 30f670f11a130e1bd9a7eb60865dc4f67431ecd9 by Daniel Faust.
Committed on 08/08/2011 at 16:10.
Pushed by dfaust into branch 'master'.

Use QGraphicsScene::NoIndex instead of QGraphicsScene::BspTreeIndex (avoid Qt bug crashing amarok)

BUG: 207382
BUG: 269227
FIXED-IN: 2.4.4

M  +2    -1    src/context/ContextView.cpp
M  +1    -0    ChangeLog

http://commits.kde.org/amarok/30f670f11a130e1bd9a7eb60865dc4f67431ecd9

diff --git a/ChangeLog b/ChangeLog
index 52fbf8c..887d1ee 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -10,6 +10,7 @@ Version 2.4.4-Beta 1
     * Current track applet: show number of artists instead of genres. (BR 261077)
 
   BUGFIXES:
+    * Work around a Qt bug that crashed Amarok in various situations. (BR 207382, BR 269227)
     * Fixed issue with TagDialog that brought to messed up digits order in numerical
       fields (year, track, disk, score). (BR 277279)
     * Made possible to store empty TagDialog's numerical fields. (BR 278921)
diff --git a/src/context/ContextView.cpp b/src/context/ContextView.cpp
index e90c262..aeff316 100644
--- a/src/context/ContextView.cpp
+++ b/src/context/ContextView.cpp
@@ -54,7 +54,8 @@ ContextView::ContextView( Plasma::Containment *cont, Plasma::Corona *corona, QWi
 
     s_self = this;
 
-    scene()->setItemIndexMethod( QGraphicsScene::BspTreeIndex );
+    // using QGraphicsScene::BspTreeIndex leads to crashes in some Qt versions
+    scene()->setItemIndexMethod( QGraphicsScene::NoIndex );
     //TODO: Figure out a way to use rubberband and ScrollHandDrag
     //setDragMode( QGraphicsView::RubberBandDrag );
     setTransformationAnchor( QGraphicsView::NoAnchor );

[prev in list] [next in list] [prev in thread] [next in thread]