[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    extragear/office/kmymoney
From:       Cristian Oneț <onet.cristian () gmail ! com>
Date:       2011-07-22 21:24:19
Message-ID: 20110722212419.5DCBAAC74F () svn ! kde ! org
[Download RAW message or body]

SVN commit 1242789 by conet:

Re-enable all the warnings. Removed some ignored const qualifiers - the const \
qualifier is only ignored for non-class type return values (enum and the pointer - \
the pointed to object is still const).

 M  +0 -5      CMakeLists.txt  
 M  +2 -2      kmymoney/mymoney/mymoneymoney.cpp  
 M  +2 -2      kmymoney/mymoney/mymoneymoney.h  
 M  +1 -1      kmymoney/mymoney/mymoneyobjectcontainer.cpp  
 M  +1 -1      kmymoney/mymoney/mymoneyobjectcontainer.h  


--- trunk/extragear/office/kmymoney/CMakeLists.txt #1242788:1242789
@@ -229,12 +229,7 @@
 # tells gcc to enable exception handling
 SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${KDE4_ENABLE_EXCEPTIONS}")
 
-# temporarily disable the hidden base class virtual functions warning
-# so we can concetrate on the more important compiler warnings
-# also disable "type qualifiers ignored on function return type"
-#since we can't do anything about KDChart code
 IF(CMAKE_SYSTEM_NAME MATCHES Linux)
-  SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-ignored-qualifiers")
   SET(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -Wl,--as-needed")
   SET(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Wl,--as-needed")
 ENDIF(CMAKE_SYSTEM_NAME MATCHES Linux)
--- trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoney.cpp \
#1242788:1242789 @@ -63,7 +63,7 @@
   _negativeMonetarySignPosition = pos;
 }
 
-const MyMoneyMoney::signPosition MyMoneyMoney::negativeMonetarySignPosition(void)
+MyMoneyMoney::signPosition MyMoneyMoney::negativeMonetarySignPosition(void)
 {
   return _negativeMonetarySignPosition;
 }
@@ -73,7 +73,7 @@
   _positiveMonetarySignPosition = pos;
 }
 
-const MyMoneyMoney::signPosition MyMoneyMoney::positiveMonetarySignPosition(void)
+MyMoneyMoney::signPosition MyMoneyMoney::positiveMonetarySignPosition(void)
 {
   return _positiveMonetarySignPosition;
 }
--- trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoney.h #1242788:1242789
@@ -157,8 +157,8 @@
 
   static const QChar thousandSeparator(void);
   static const QChar decimalSeparator(void);
-  static const signPosition negativeMonetarySignPosition(void);
-  static const signPosition positiveMonetarySignPosition(void);
+  static signPosition negativeMonetarySignPosition(void);
+  static signPosition positiveMonetarySignPosition(void);
   static void setFileVersion(const fileVersionE version);
 
   const MyMoneyMoney& operator=(const QString& pszAmount);
--- trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyobjectcontainer.cpp \
#1242788:1242789 @@ -56,7 +56,7 @@
   }
 }
 
-const MyMoneyObject * const MyMoneyObjectContainer::object(const QString& id) const
+const MyMoneyObject * MyMoneyObjectContainer::object(const QString& id) const
 {
   QMap<QString, MyMoneyObject const *>::const_iterator it;
   it = m_map.find(id);
--- trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyobjectcontainer.h \
#1242788:1242789 @@ -81,7 +81,7 @@
 
   const MyMoneyAccount& accountByName(const QString& name) const;
 
-  const MyMoneyObject * const object(const QString& id) const;
+  const MyMoneyObject * object(const QString& id) const;
 
   /**
    * This method refreshes an already existing object in the container


[prev in list] [next in list] [prev in thread] [next in thread]