[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    =?utf-8?q?=5Bphonon-gstreamer=5D_gstreamer=3A_if_you_write_a_cpp?=
From:       Harald Sitter <sitter () kde ! org>
Date:       2011-06-21 18:19:15
Message-ID: 20110621181915.6863FA60A6 () git ! kde ! org
[Download RAW message or body]

Git commit 6935a389603cd21290b9101f483449820af2db3f by Harald Sitter.
Committed on 21/06/2011 at 20:18.
Pushed by sitter into branch 'master'.

if you write a cpp gst sink, thenat least use bools :S

M  +6    -6    gstreamer/phononsrc.cpp     

http://commits.kde.org/phonon-gstreamer/6935a389603cd21290b9101f483449820af2db3f

diff --git a/gstreamer/phononsrc.cpp b/gstreamer/phononsrc.cpp
index b0265c1..8c4c00d 100644
--- a/gstreamer/phononsrc.cpp
+++ b/gstreamer/phononsrc.cpp
@@ -63,8 +63,8 @@ static GstFlowReturn phonon_src_create(GstBaseSrc *src, guint64 offset,
 static gboolean register_elements(GstPlugin *plugin)
 {
     if (!gst_element_register(plugin, "phononsrc", GST_RANK_NONE, GST_TYPE_PHONON_SRC))
-        return FALSE;
-    return TRUE;
+        return false;
+    return true;
 }
 
 gboolean register_phonon_elements()
@@ -80,7 +80,7 @@ gboolean register_phonon_elements()
         "phonon",
         "phonon",
         "http://phonon.kde.org");
-    return TRUE;
+    return true;
 }
 
 static void _do_init(GType filesrc_type)
@@ -168,14 +168,14 @@ static gboolean phonon_src_set_device(PhononSrc *src, StreamReader *device)
 
     src->device = device;
     g_object_notify(G_OBJECT (src), "iodevice");
-    return TRUE;
+    return true;
 
     // Error
 wrong_state:
     {
         //GST_DEBUG_OBJECT (src, "setting location in wrong state");
         GST_OBJECT_UNLOCK (src);
-        return FALSE;
+        return false;
     }
 }
 #endif //QT_NO_PHONON_ABSTRACTMEDIASTREAM
@@ -321,7 +321,7 @@ static gboolean phonon_src_stop(GstBaseSrc *basesrc)
     // the reader is unlocked and send a final enoughData.
     PhononSrc *src = GST_PHONON_SRC(basesrc);
     src->device->stop();
-    return TRUE;
+    return true;
 #endif // QT_NO_PHONON_ABSTRACTMEDIASTREAM
     return false;
 }

[prev in list] [next in list] [prev in thread] [next in thread]